You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/20 00:16:59 UTC

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6945: Add the complex-type support to

siddharthteotia commented on a change in pull request #6945:
URL: https://github.com/apache/incubator-pinot/pull/6945#discussion_r635663425



##########
File path: pinot-tools/src/main/resources/examples/stream/meetupRsvp/complexTypeHandling_meetupRsvp_realtime_table_config.json
##########
@@ -26,23 +26,13 @@
       ]
     },
     "transformConfigs": [
-      {
-        "columnName": "group_json",
-        "transformFunction": "jsonFormat(\"group\")"
-      }
     ],
     "complexTypeConfig": {
       "unnestFields": ["group.group_topics"]
     }

Review comment:
       Now that we have schema inference and can see the fully exploded schema after unnesting, can we add a test to unnest a collection which also has an inner collection. I think we added a TODO for the same in previous PR ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org