You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alexey Neyman <al...@auriga.ru> on 2006/06/06 14:31:46 UTC

Patch ping: diff output specification

Hi there,

A week ago I submitted a patch that allows one to specify which 
changes need to be output into the 'svn diff' output. The original 
letter (with the patch) is here:

http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=116258

The problems I'm trying to solve are described here:

http://subversion.tigris.org/servlets/ReadMsg?list=users&msgNo=49807
http://subversion.tigris.org/servlets/ReadMsg?list=users&msgNo=49808

Also, I saw this feature being requested several times on the list:

http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=38297
http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=83591
http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=70211
http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=91272
<more requests skipped>

Slightly updated patch attached to this letter. The patch applies to 
subversion 1.3.1 and passes 'make check'. If there's interest in it, 
I'll update it to apply against trunk, add doxygen-style comments, 
create test case and so on.

Regards,
Alexey.

-- 
If you have `Peace', you simply haven't yet seen the thing
that's trying to kill you.
                        -- Spathi captain Fwiffo, SC2

Re: Patch ping: diff output specification

Posted by Ben Collins-Sussman <su...@red-bean.com>.
Thanks!   But I think you're too late.  Two things:

* Before writing code, ask on the list for the latest state of the
union on an issue.  'svn diff --summarize' has been in svn 1.4 for
months, and you probably just did a bunch of work for no reason.  :-(

* In the future, when writing a patch, write it against the latest
trunk code, not against a snapshot of prior release.  All new code
goes into the trunk, so if you don't develop against the trunk, then
there's a risk your patch won't apply cleanly.



On 6/6/06, Alexey Neyman <al...@auriga.ru> wrote:
> Hi there,
>
> A week ago I submitted a patch that allows one to specify which
> changes need to be output into the 'svn diff' output. The original
> letter (with the patch) is here:
>
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=116258
>
> The problems I'm trying to solve are described here:
>
> http://subversion.tigris.org/servlets/ReadMsg?list=users&msgNo=49807
> http://subversion.tigris.org/servlets/ReadMsg?list=users&msgNo=49808
>
> Also, I saw this feature being requested several times on the list:
>
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=38297
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=83591
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=70211
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=91272
> <more requests skipped>
>
> Slightly updated patch attached to this letter. The patch applies to
> subversion 1.3.1 and passes 'make check'. If there's interest in it,
> I'll update it to apply against trunk, add doxygen-style comments,
> create test case and so on.
>
> Regards,
> Alexey.
>
> --
> If you have `Peace', you simply haven't yet seen the thing
> that's trying to kill you.
>                         -- Spathi captain Fwiffo, SC2
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org