You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "M4n5ter (via GitHub)" <gi...@apache.org> on 2026/09/09 10:41:59 UTC
[PR] fix(desktop): round transparent WorkHub floating windows [maka]
M4n5ter opened a new pull request, #5105:
URL: https://github.com/apache/maka/pull/5105
## Summary
Follow-up to #4979: expanded and compact WorkHub windows had square edges on Windows because their transparent native window was expected to clip the renderer. [Windows does not round windows using per-pixel alpha layering](https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/ui/apply-rounded-corners#why-isnt-my-app-rounded).
Give the floating surface and the global grain overlay the same 20px corner radius. Clipping the overlay also removes the faint rectangular residue outside the surface. Docked WorkHub keeps its existing shape.
## Verification
- Full build, lint, format, workspace typechecks, and Desktop/UI Knip passed.
- All three existing WorkHub Electron layout/reconstruction tests passed.
- A temporary Electron pixel probe captured before/after images in expanded/compact and light/dark states; all four corner alpha values become zero. Removing the rounding makes the zero-alpha check fail. This probe was used for visual verification and is not part of the committed change.
```text
Before corner alpha After corner alpha
expanded, light/dark [223, 218, 248, 246] [0, 0, 0, 0]
compact, light/dark [224, 212, 250, 246] [0, 0, 0, 0]
Electron checks 4 passed (37.4s)
```
Local visual verification used macOS/Electron; a native Windows visual pass was not available.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented and verified the CSS fix and drafted this PR.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): round transparent WorkHub floating windows [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #5105:
URL: https://github.com/apache/maka/pull/5105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org