[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8274: Add missing tuningConfigs for auto compaction

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #8274: Add missing tuningConfigs for auto compaction
URL: https://github.com/apache/incubator-druid/pull/8274#discussion_r312321709
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/coordinator/DataSourceCompactionConfig.java
 ##########
 @@ -237,13 +238,26 @@ public int hashCode()
     @JsonCreator
     public UserCompactTuningConfig(
         @JsonProperty("maxRowsInMemory") @Nullable Integer maxRowsInMemory,
-        @JsonProperty("maxTotalRows") @Nullable Integer maxTotalRows,
+        @JsonProperty("maxBytesInMemory") @Nullable Long maxBytesInMemory,
 
 Review comment:
   Do these need to be added to docs too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org