[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1430: SOLR-13101: SHARED replica's distributed indexing

[GitBox <gi...@apache.org>]

mbwaheed commented on a change in pull request #1430:
URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425514283



##########
File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
##########
@@ -114,16 +104,29 @@
   private RollupRequestReplicationTracker rollupReplicationTracker;
   private LeaderRequestReplicationTracker leaderReplicationTracker;
 
+  /**
+   * For {@link Replica.Type#SHARED} replica, it is necessary that we pull from the shared store at the start of
+   * an indexing batch (if the core is stale). And we push to the shared store at the end of a successfully committed
+   * indexing batch (we ensure that each batch has a hard commit). Details can be found in 
+   * {@link org.apache.solr.store.shared.SharedCoreConcurrencyController}.
+   * In other words, we would like to call {@link SharedCoreIndexingBatchProcessor#startIndexingBatch()} at the start of

Review comment:
       I never liked this place to run batch start/finish logic. I have added a TODO.
   
   The doc also refers addOrDeleteGoingToBeIndexedLocally and hardCommitCompletedLocally few lines later.
   startIndexingBatch and finishIndexingBatch are mentioned first because they are the real reason for whole logic. They are not public because they don't need to be. But if/when we find another better place to start/finish a batch we will likely make them public and directly call them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org