You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/01 04:09:12 UTC
[GitHub] john-bodley opened a new pull request #6963: [sql-parse] Fixing
LIMIT exceptions
john-bodley opened a new pull request #6963: [sql-parse] Fixing LIMIT exceptions
URL: https://github.com/apache/incubator-superset/pull/6963
This PR fixes an issue when trying to extract the `LIMIT` from a query and the `LIMIT` value is either missing or ill-defined which previously would raise a series of exceptions `IndexError`, `TypeError`, etc. which would result in an `Internal Server Error` (500) being thrown.
Note if no valid `LIMIT` can be extracted we simply return `None` and allow the underlying database engine to flag the issue during parsing.
to: @michellethomas @mistercrunch
cc: @timifasubaa
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org