You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/21 20:17:23 UTC

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs 

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6452

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................

IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Update all URLs in *keydefs* file that point to
issues.cloudera.org.

Update all <xref> tags in the doc source that point
to individual JIRA issues on issues.cloudera.org.
(Leave alone links pointing to JIRA reports; those
don't seem to be redirected currently.)

Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_new_features.xml
7 files changed, 10,393 insertions(+), 10,413 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6452/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 2: Code-Review+1

My concerns are addressed.

-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Update all URLs in *keydefs* file that point to
issues.cloudera.org.

Update all <xref> tags in the doc source that point
to individual JIRA issues on issues.cloudera.org.
(Leave alone links pointing to JIRA reports; those
don't seem to be redirected currently.)

Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Reviewed-on: http://gerrit.cloudera.org:8080/6452
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_new_features.xml
7 files changed, 10,393 insertions(+), 10,413 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Brown: Looks good to me, but someone else must approve
  Laurel Hale: Looks good to me, but someone else must approve
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6452/1/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:

PS1, Line 316:   <keydef href="https://issues.apache.org/jira/browse/IMPALA-1" scope="external" format="html" keys="IMPALA-1"/>
> Unrelated to this review, but: This is wild! Is there a way to just have a 
No, XML really likes the generated output to be extremely predictable based on simple parsing of the input source files. Sometimes we employ postprocessing but (a) that's more complicated for an open source user to set up, and (b) the result would only apply to HTML output, whereas these links will work equally in HTML and PDF.


http://gerrit.cloudera.org:8080/#/c/6452/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:

PS1, Line 50:      <xref href="https://issues.apache.org/" scope="external" format="html">issues.apache.org JIRA tracker</xref>.
> If you look https://issues.apache.org/ is a page that gives you links to va
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 1:

The changes to the <xref> tags pointing to Impala issues were done by macro, so if the basic pattern is correct I don't they need to be checked one-by-one.

I also found a couple of HIVE- JIRA URLs pointing to issues.cloudera.org. I confirmed that the equivalent issues.apache.org/jira URLs worked and so changed those links where appropriate.

-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 1:

(2 comments)

I need to set up dita locally before I give you any pluses, but here are my comments so far.

http://gerrit.cloudera.org:8080/#/c/6452/1/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:

PS1, Line 316:   <keydef href="https://issues.apache.org/jira/browse/IMPALA-1" scope="external" format="html" keys="IMPALA-1"/>
Unrelated to this review, but: This is wild! Is there a way to just have a macro so that these things "just work" without all the explicit definitions?


http://gerrit.cloudera.org:8080/#/c/6452/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:

PS1, Line 50:      <xref href="https://issues.apache.org/" scope="external" format="html">issues.apache.org JIRA tracker</xref>.
If you look https://issues.apache.org/ is a page that gives you links to various bug-tracking sites for ASF. Maybe prefer https://issues.apache.org/jira/ when talking about the top-level site?


-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................

IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Update all URLs in *keydefs* file that point to
issues.cloudera.org.

Update all <xref> tags in the doc source that point
to individual JIRA issues on issues.cloudera.org.
(Leave alone links pointing to JIRA reports; those
don't seem to be redirected currently.)

Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_new_features.xml
7 files changed, 10,393 insertions(+), 10,413 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6452/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 2: Code-Review+1

Built cleanly, fixes display as expected in all files after a spot check (both html & pdf)

-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/105/

-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No