You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "fat-catTW (via GitHub)" <gi...@apache.org> on 2026/03/01 06:17:48 UTC

[PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

fat-catTW opened a new pull request, #62652:
URL: https://github.com/apache/airflow/pull/62652

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   ## Description
   
   This PR completes the Traditional Chinese (zh-TW) translations for Airflow UI.
   
   Added 10 missing translation keys:
   - `pendingDagRun_one` and `pendingDagRun_other`
   - `partitionedDagRun_one` and `partitionedDagRun_other`
   - `partitionedDagRunDetail.receivedAssetEvents`
   - `panel.showVersionIndicator` (label and 4 options)
   
   This achieves 100% zh-TW translation coverage (786/786 keys).
   
   Verified via:
   - `breeze ui check-translation-completeness --language zh-TW` 
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ X] Yes (please specify the tool below)
   
   
   Generated-by: Copilot following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #62652:
URL: https://github.com/apache/airflow/pull/62652#issuecomment-3996247423

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "fat-catTW (via GitHub)" <gi...@apache.org>.
fat-catTW commented on PR #62652:
URL: https://github.com/apache/airflow/pull/62652#issuecomment-3982761497

   I changed 「分割」 to 「分區」, updated the "Additional Terminology" section in Translation Skills, and left 「待執行」 unchanged.
   Thanks for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #62652:
URL: https://github.com/apache/airflow/pull/62652#discussion_r2868698981


##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",

Review Comment:
   We have translated "partition" as "分區“ so far, "分區的" might be more suitable.
   
   Perhaps we could add partition -> 分區 under "Additional Terminology" section in the translation skills 
   
   https://github.com/apache/airflow/blob/826f5df0e5f77f8abe97f6d520f4ecfe66a4da2b/.github/skills/airflow-translations/locales/zh-TW.md#L147-L154



##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",
+  "partitionedDagRunDetail": {
+    "receivedAssetEvents": "收到的資源事件"
+  },
+  "pendingDagRun_one": "待執行的 Dag 執行",
+  "pendingDagRun_other": "待執行的 Dag 執行",

Review Comment:
   How about "待回應" instead of "待執行"?
   
   https://github.com/apache/airflow/blob/436e59a28049d7a3b4e343274b4e2a36e06b7441/airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/hitl.json#L7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #62652:
URL: https://github.com/apache/airflow/pull/62652#discussion_r2870328138


##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",

Review Comment:
   +1 for 分區的
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #62652:
URL: https://github.com/apache/airflow/pull/62652#discussion_r2870918899


##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",
+  "partitionedDagRunDetail": {
+    "receivedAssetEvents": "收到的資源事件"
+  },
+  "pendingDagRun_one": "待執行的 Dag 執行",
+  "pendingDagRun_other": "待執行的 Dag 執行",

Review Comment:
   Sure! Let's go for "待執行". Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "fat-catTW (via GitHub)" <gi...@apache.org>.
fat-catTW commented on PR #62652:
URL: https://github.com/apache/airflow/pull/62652#issuecomment-3991760503

   I attempted to run the E2E tests locally but encountered a Docker build error (SIGBUS fault), 
   which appears to be an environment issue.
   
   My PR only modifies translation files:
   - `.github/skills/airflow-translations/locales/zh-TW.md`
   - `airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json`
   - `airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json`
   
   I think the failing E2E tests (`dag-calendar-tab.spec.ts`, `task-instances.spec.ts`) are unrelated 
   to translation content.
   
   Could you please re-run the tests? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #62652:
URL: https://github.com/apache/airflow/pull/62652


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #62652:
URL: https://github.com/apache/airflow/pull/62652#discussion_r2870145511


##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",

Review Comment:
   sounds like a good idea



##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",
+  "partitionedDagRunDetail": {
+    "receivedAssetEvents": "收到的資源事件"
+  },
+  "pendingDagRun_one": "待執行的 Dag 執行",
+  "pendingDagRun_other": "待執行的 Dag 執行",

Review Comment:
   I don't think this is "待回應".  "待執行" is probably ok. but @guan404ming might have a better idea?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(i18n): Complete zh-TW translations - Add 10 missing keys [airflow]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #62652:
URL: https://github.com/apache/airflow/pull/62652#discussion_r2870329796


##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -161,6 +161,13 @@
     "placeholder": "新增筆記...",
     "taskInstance": "任務實例筆記"
   },
+  "partitionedDagRun_one": "分割的 Dag 執行",
+  "partitionedDagRun_other": "分割的 Dag 執行",
+  "partitionedDagRunDetail": {
+    "receivedAssetEvents": "收到的資源事件"
+  },
+  "pendingDagRun_one": "待執行的 Dag 執行",
+  "pendingDagRun_other": "待執行的 Dag 執行",

Review Comment:
   I would prefer "待執行". But open to any better option!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org