You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "LoganZhuZzz (via GitHub)" <gi...@apache.org> on 2025/03/31 07:45:48 UTC
[PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
LoganZhuZzz opened a new pull request, #19320:
URL: https://github.com/apache/kafka/pull/19320
Removes outdated references to Kafka 0.10.x in the clients module documentation. Since the baseline version is now 2.1, any mentions of versions earlier than this are unnecessary and have been removed or updated accordingly.
Changes:
- Updated ClusterResource, ClusterResourceListener, and DescribeClusterResult Javadoc to reflect the minimum supported broker version as 2.1.
- Removed references to 0.10.x and adjusted explanations to remain relevant for newer versions.
Testing & Impact:
- This PR only modifies Javadoc comments—no functional code changes.
- No impact on existing functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19320:
URL: https://github.com/apache/kafka/pull/19320#issuecomment-2776952680
@ijuma thanks for all your reviews. we will file a minor patch tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19320:
URL: https://github.com/apache/kafka/pull/19320#issuecomment-2768656521
> OffsetFetcherUtils also contains logic related to 0.10.x support. However, I’m not sure if it aligns with the scope of the [JIRA issue](https://issues.apache.org/jira/browse/KAFKA-19055). Should we clean it up in this PR as well?
yes, please revise it as well. Also, please add this changes to the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "LoganZhuZzz (via GitHub)" <gi...@apache.org>.
LoganZhuZzz commented on code in PR #19320:
URL: https://github.com/apache/kafka/pull/19320#discussion_r2022164085
##########
clients/src/main/java/org/apache/kafka/common/ClusterResourceListener.java:
##########
@@ -24,7 +24,7 @@
* <p>
* <h4>Clients</h4>
* There will be one invocation of {@link ClusterResourceListener#onUpdate(ClusterResource)} after each metadata response.
- * Note that the cluster id may be null when the Kafka broker version is below 0.10.1.0. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running.
+ * Note the minimum supported broker version is 2.1. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running.
Review Comment:
> It is impossible to have "null" cluster id for now, right?
I will remove the outdated part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19320:
URL: https://github.com/apache/kafka/pull/19320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "LoganZhuZzz (via GitHub)" <gi...@apache.org>.
LoganZhuZzz commented on PR #19320:
URL: https://github.com/apache/kafka/pull/19320#issuecomment-2768450569
> Not sure whether we can also remove these lines if we drop support for version below 2.1?
>
> https://github.com/apache/kafka/blob/6f4d4255a6b6d2585d182db46228a0a13a9c5176/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java#L110-L111
`OffsetFetcherUtils` also contains logic related to 0.10.x support. However, I’m not sure if it aligns with the scope of the [JIRA issue](https://issues.apache.org/jira/browse/KAFKA-19055). Should we clean it up in this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #19320:
URL: https://github.com/apache/kafka/pull/19320#discussion_r2027717639
##########
clients/src/main/java/org/apache/kafka/common/ClusterResourceListener.java:
##########
@@ -24,7 +24,7 @@
* <p>
* <h4>Clients</h4>
* There will be one invocation of {@link ClusterResourceListener#onUpdate(ClusterResource)} after each metadata response.
- * Note that the cluster id may be null when the Kafka broker version is below 0.10.1.0. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running.
+ * Note the minimum supported broker version is 2.1.
Review Comment:
I think we can remove this line altogether. Best to avoid having versions mentioned in every class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19320:
URL: https://github.com/apache/kafka/pull/19320#discussion_r2021417242
##########
clients/src/main/java/org/apache/kafka/common/ClusterResourceListener.java:
##########
@@ -24,7 +24,7 @@
* <p>
* <h4>Clients</h4>
* There will be one invocation of {@link ClusterResourceListener#onUpdate(ClusterResource)} after each metadata response.
- * Note that the cluster id may be null when the Kafka broker version is below 0.10.1.0. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running.
+ * Note the minimum supported broker version is 2.1. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running.
Review Comment:
It is impossible to have "null" cluster id for now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19055: Cleanup the 0.10.x information from clients module [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #19320:
URL: https://github.com/apache/kafka/pull/19320#discussion_r2027719011
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -107,8 +107,6 @@ public class TopicConfig {
public static final String MAX_MESSAGE_BYTES_CONFIG = "max.message.bytes";
public static final String MAX_MESSAGE_BYTES_DOC =
"The largest record batch size allowed by Kafka (after compression if compression is enabled). " +
- "If this is increased and there are consumers older than 0.10.2, the consumers' fetch " +
- "size must also be increased so that they can fetch record batches this large. " +
"In the latest message format version, records are always grouped into batches for efficiency. " +
"In previous message format versions, uncompressed records are not grouped into batches and this " +
"limit only applies to a single record in that case.";
Review Comment:
We can also delete all these lines. The only thing we need to remain is "The largest record batch size allowed by Kafka (after compression if compression is enabled)."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org