You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/10/05 22:35:25 UTC
[kudu-CR] Bump Sentry and Hadoop versions
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11601
Change subject: Bump Sentry and Hadoop versions
......................................................................
Bump Sentry and Hadoop versions
The motivation is to get access to SENTRY-2371, which introduces a new
Thrift interface that will be used by Kudu to retrieve user privileges.
SENTRY-2371 has not been released yet, so the new Sentry version is
based on the latest commit of the master branch. The new Sentry version
appears to have an incompatibility with Hadoop 2.7.2, so this also
includes a bump to the latest Hadoop 2.7.x version. I suspect the fix
between 2.7.2 and 2.7.5 was introduced in [1], but the commit message is
vague and I haven't dug any further. The incompatiblity manifests as an
exception during Sentry startup:
java.lang.NoSuchMethodError: org.apache.hadoop.conf.Configuration.addResource(Ljava/net/URL;Z)V
at org.apache.sentry.service.thrift.SentryService.loadConfig(SentryService.java:576)
at org.apache.sentry.service.thrift.SentryService$CommandImpl.run(SentryService.java:600)
at org.apache.sentry.SentryMain.main(SentryMain.java:120)
[1]: https://github.com/apache/hadoop/commit/7af9b8ad1e993ef791aa38740b6aabc4c233a30f
Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
---
M src/kudu/sentry/sentry_common_service.thrift
M src/kudu/sentry/sentry_policy_service.thrift
M thirdparty/vars.sh
3 files changed, 99 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/11601/1
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
[kudu-CR] Bump Sentry and Hadoop versions
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11601 )
Change subject: Bump Sentry and Hadoop versions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Oct 2018 00:15:59 +0000
Gerrit-HasComments: No
[kudu-CR] Bump Sentry and Hadoop versions
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11601 )
Change subject: Bump Sentry and Hadoop versions
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11601/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11601/1//COMMIT_MSG@14
PS1, Line 14: 2.7.x
Do you mean 2.8.x? I saw 2.8.5 is used in vars.sh.
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Oct 2018 22:54:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] Bump Sentry and Hadoop versions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11601 )
Change subject: Bump Sentry and Hadoop versions
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11601/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11601/1//COMMIT_MSG@14
PS1, Line 14: 2.8.x
> Do you mean 2.8.x? I saw 2.8.5 is used in vars.sh.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Oct 2018 00:07:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] Bump Sentry and Hadoop versions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11601 )
Change subject: Bump Sentry and Hadoop versions
......................................................................
Bump Sentry and Hadoop versions
The motivation is to get access to SENTRY-2371, which introduces a new
Thrift interface that will be used by Kudu to retrieve user privileges.
SENTRY-2371 has not been released yet, so the new Sentry version is
based on the latest commit of the master branch. The new Sentry version
appears to have an incompatibility with Hadoop 2.8.2, so this also
includes a bump to the latest Hadoop 2.8.x version. I suspect the fix
between 2.8.2 and 2.8.5 was introduced in [1], but the commit message is
vague and I haven't dug any further. The incompatiblity manifests as an
exception during Sentry startup:
java.lang.NoSuchMethodError: org.apache.hadoop.conf.Configuration.addResource(Ljava/net/URL;Z)V
at org.apache.sentry.service.thrift.SentryService.loadConfig(SentryService.java:576)
at org.apache.sentry.service.thrift.SentryService$CommandImpl.run(SentryService.java:600)
at org.apache.sentry.SentryMain.main(SentryMain.java:120)
[1]: https://github.com/apache/hadoop/commit/7af9b8ad1e993ef791aa38740b6aabc4c233a30f
Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Reviewed-on: http://gerrit.cloudera.org:8080/11601
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/sentry/sentry_common_service.thrift
M src/kudu/sentry/sentry_policy_service.thrift
M thirdparty/vars.sh
3 files changed, 99 insertions(+), 10 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Bump Sentry and Hadoop versions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11601
to look at the new patch set (#2).
Change subject: Bump Sentry and Hadoop versions
......................................................................
Bump Sentry and Hadoop versions
The motivation is to get access to SENTRY-2371, which introduces a new
Thrift interface that will be used by Kudu to retrieve user privileges.
SENTRY-2371 has not been released yet, so the new Sentry version is
based on the latest commit of the master branch. The new Sentry version
appears to have an incompatibility with Hadoop 2.8.2, so this also
includes a bump to the latest Hadoop 2.8.x version. I suspect the fix
between 2.8.2 and 2.8.5 was introduced in [1], but the commit message is
vague and I haven't dug any further. The incompatiblity manifests as an
exception during Sentry startup:
java.lang.NoSuchMethodError: org.apache.hadoop.conf.Configuration.addResource(Ljava/net/URL;Z)V
at org.apache.sentry.service.thrift.SentryService.loadConfig(SentryService.java:576)
at org.apache.sentry.service.thrift.SentryService$CommandImpl.run(SentryService.java:600)
at org.apache.sentry.SentryMain.main(SentryMain.java:120)
[1]: https://github.com/apache/hadoop/commit/7af9b8ad1e993ef791aa38740b6aabc4c233a30f
Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
---
M src/kudu/sentry/sentry_common_service.thrift
M src/kudu/sentry/sentry_policy_service.thrift
M thirdparty/vars.sh
3 files changed, 99 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/11601/2
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Bump Sentry and Hadoop versions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11601 )
Change subject: Bump Sentry and Hadoop versions
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bcc4ff6fac0435b037b984f45da75bed6ff4be5
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Oct 2018 22:55:04 +0000
Gerrit-HasComments: No