You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by al...@collab.net on 2005/05/23 08:18:20 UTC

[PATCH] 'svn info --xml'

[[[
Patch to add XML output for 'svn info'

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table[]): added --xml and --incremental options
  for svn info

* subversion/clients/cmdline/dtd/info.dtd
  New dtd for info --xml

* subversion/clients/cmdline/info-cmd.c
  (print_header_xml): New function to print XML header
  (print_target_xml): New function to print open and close targets
  (print_footer_xml): New function to print XML footer
  (print_info_xml): New function for XML output
  (info_receiver): Edited existing callback to call function to
   print xml or traditional output depending on cmdline option
  (svn_cl__info): Modified for XML output and redirected errors to stderr

* tools/client-side/bash_completion
  (_svn): added "--incremental" and "--xml" options to "info"
  for auto-completion.
]]]


Re: [PATCH] 'svn info --xml'

Posted by "Øyvind A. Holm" <su...@sunbase.org>.
On 2005-05-23 12:18:57 Peter N. Lundblad wrote:
> On Mon, 23 May 2005 alexander@collab.net wrote:
> > Patch to add XML output for 'svn info'
>
> Looking at the svn info output, I don't think this is necessary.

Uhm, yes, I think it's necessary. I have some scripts which calls svn 
info, and when I ran it in a non-English locale it broke because the 
messages is I18Ned. More specifically, the URL: line had changed. IMHO, 
all places where I18N is done there should be an --xml option to ensure 
the scripts will continue to work in all locales.

I'll check out this patch myself, btw. I love XML stuff. :)

-- sunny256

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] 'svn info --xml'

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 23 May 2005, [utf-8] �^Xyvind A. Holm wrote:

> On 2005-05-23 12:18:57 Peter N. Lundblad wrote:
> > On Mon, 23 May 2005 alexander@collab.net wrote:
> > > Patch to add XML output for 'svn info'
> >
> > Looking at the svn info output, I don't think this is necessary.
>
> Uhm, yes, I think it's necessary. I have some scripts which calls svn
> info, and when I ran it in a non-English locale it broke because the
> messages is I18Ned. More specifically, the URL: line had changed. IMHO,
> all places where I18N is done there should be an --xml option to ensure
> the scripts will continue to work in all locales.
>
The script could also set LC_MESSAGES=C. But, that will also make error
messages into English, which might be undesirable.

OK, I guess I'm convinced then. :-) It's no big deal, afterall.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: [PATCH] 'svn info --xml'

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 23 May 2005 alexander@collab.net wrote:

> [[[
> Patch to add XML output for 'svn info'
>
Looking at the svn info output, I don't think this is necessary.

the output is sufficiently easy to parse and extend.

(BTW, I'm reviewing your patch for svn log.)

Best,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org