[GitHub] Myasuka commented on a change in pull request #7600: [FLINK-11368][tests] Port TaskManagerStartupTest to new code base

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #7600: [FLINK-11368][tests] Port TaskManagerStartupTest to new code base
URL: https://github.com/apache/flink/pull/7600#discussion_r252693919
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunnerStartupTest.java
 ##########
 @@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.taskexecutor;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.CoreOptions;
+import org.apache.flink.configuration.IllegalConfigurationException;
+import org.apache.flink.configuration.MemorySize;
+import org.apache.flink.configuration.TaskManagerOptions;
+import org.apache.flink.runtime.blob.BlobCacheService;
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.runtime.heartbeat.HeartbeatServices;
+import org.apache.flink.runtime.highavailability.HighAvailabilityServices;
+import org.apache.flink.runtime.metrics.NoOpMetricRegistry;
+import org.apache.flink.runtime.rpc.FatalErrorHandler;
+import org.apache.flink.runtime.rpc.RpcService;
+import org.apache.flink.util.IOUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.commons.io.FileUtils;
+import org.junit.Assume;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.InetAddress;
+import java.net.ServerSocket;
+
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeNoException;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * Tests that check how the {@link TaskManagerRunner} behaves when encountering startup problems.
+ */
+public class TaskManagerRunnerStartupTest extends TestLogger {
+
+	private static final String LOCAL_HOST = "localhost";
+
+	@Rule
+	public TemporaryFolder tempFolder = new TemporaryFolder();
+
+	private RpcService rpcService = createRpcService();
+
+	/**
+	 * Tests that the TaskManagerRunner startup fails synchronously when the I/O
+	 * directories are not writable.
+	 */
+	@Test
+	public void testIODirectoryNotWritable() throws Exception {
+		File nonWritable = tempFolder.newFolder();
+		Assume.assumeTrue("Cannot create non-writable temporary file directory. Skipping test.",
+			nonWritable.setWritable(false, false));
+
+		try {
+			Configuration cfg = new Configuration();
+			cfg.setString(CoreOptions.TMP_DIRS, nonWritable.getAbsolutePath());
+
+			try {
+				TaskManagerRunner.startTaskManager(
+					cfg,
+					ResourceID.generate(),
+					rpcService,
+					mock(HighAvailabilityServices.class),
+					mock(HeartbeatServices.class),
+					NoOpMetricRegistry.INSTANCE,
+					mock(BlobCacheService.class),
+					false,
+					mock(FatalErrorHandler.class));
+
+				fail("Should fail synchronously with an exception");
+			} catch (IOException e) {
+				// splendid!
+			}
+		} catch (Exception e) {
+			e.printStackTrace();
+			fail(e.getMessage());
+		} finally {
+			// noinspection ResultOfMethodCallIgnored
+			nonWritable.setWritable(true, false);
+			try {
+				FileUtils.deleteDirectory(nonWritable);
+			} catch (IOException e) {
+				// best effort
+			}
+		}
+	}
+
+	/**
+	 * Tests that the TaskManagerRunner startup fails synchronously when the memory configuration is wrong.
+	 */
+	@Test
+	public void testMemoryConfigWrong() {
+		try {
+			Configuration cfg = new Configuration();
+			cfg.setBoolean(TaskManagerOptions.MANAGED_MEMORY_PRE_ALLOCATE, true);
+
+			// something invalid
+			cfg.setString(TaskManagerOptions.MANAGED_MEMORY_SIZE, "-42m");
+			try {
+				TaskManagerRunner.startTaskManager(
+					cfg,
+					ResourceID.generate(),
+					rpcService,
+					mock(HighAvailabilityServices.class),
+					mock(HeartbeatServices.class),
+					NoOpMetricRegistry.INSTANCE,
+					mock(BlobCacheService.class),
+					false,
+					mock(FatalErrorHandler.class));
+
+				fail("Should fail synchronously with an exception");
+			} catch (IllegalConfigurationException e) {
+				// splendid!
+			}
+
+			// something ridiculously high
+			final long memSize = (((long) Integer.MAX_VALUE - 1) *
+				MemorySize.parse(TaskManagerOptions.MEMORY_SEGMENT_SIZE.defaultValue()).getBytes()) >> 20;
+			cfg.setString(TaskManagerOptions.MANAGED_MEMORY_SIZE, memSize + "m");
+			try {
+				TaskManagerRunner.startTaskManager(
+					cfg,
+					ResourceID.generate(),
+					rpcService,
+					mock(HighAvailabilityServices.class),
+					mock(HeartbeatServices.class),
+					NoOpMetricRegistry.INSTANCE,
+					mock(BlobCacheService.class),
+					false,
+					mock(FatalErrorHandler.class));
+
+				fail("Should fail synchronously with an exception");
+			} catch (Exception e) {
+				// splendid!
+				assertTrue(e.getCause() instanceof OutOfMemoryError);
+			}
+		} catch(Exception e) {
+			e.printStackTrace();
+			fail(e.getMessage());
+		}
+	}
+
+	/**
+	 * Tests that the TaskManagerRunner startup fails if the network stack cannot be initialized.
+	 */
+	@Test
+	public void testStartupWhenNetworkStackFailsToInitialize() throws Exception {
+		final ServerSocket blocker = blockServerSocket();
+
+		try {
+			final Configuration cfg = new Configuration();
+			cfg.setInteger(TaskManagerOptions.DATA_PORT, blocker.getLocalPort());
+
+			TaskManagerRunner.startTaskManager(
+				cfg,
+				ResourceID.generate(),
+				rpcService,
+				mock(HighAvailabilityServices.class),
+				mock(HeartbeatServices.class),
+				NoOpMetricRegistry.INSTANCE,
+				mock(BlobCacheService.class),
+				false,
+				mock(FatalErrorHandler.class));
+
+			fail("Should throw IOException when the network stack cannot be initialized.");
+		} catch (IOException e) {
+			// ignored
+		} finally {
+			IOUtils.closeQuietly(blocker);
+		}
+	}
+
+	//-----------------------------------------------------------------------------------------------
+
+	private static RpcService createRpcService() {
+		final RpcService rpcService = mock(RpcService.class);
+		when(rpcService.getAddress()).thenReturn(LOCAL_HOST);
+		return rpcService;
+	}
+
+	private static ServerSocket blockServerSocket() {
+		try {
+			return new ServerSocket(0, 50, InetAddress.getByName(LOCAL_HOST));
+		} catch (IOException e) {
 
 Review comment:
   @zentol In my opinion, if no server could be created with arbitrary ports, which does not mean the Flink code is broken, we should just skip this test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services