You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/13 21:01:54 UTC

Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54594/
-----------------------------------------------------------

Review request for mesos and Daniel Pravat.


Repository: mesos


Description
-------

Replaced `::lseek` with `os::lseek` in mesos.


Diffs
-----

  src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 
  src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 

Diff: https://reviews.apache.org/r/54594/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54594/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 3:52 p.m.)


Review request for mesos and Daniel Pravat.


Repository: mesos


Description
-------

Replaced `::lseek` with `os::lseek` in mesos.


Diffs (updated)
-----

  src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 
  src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 

Diff: https://reviews.apache.org/r/54594/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54594/#review159210
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Pravat


On Dec. 13, 2016, 9:01 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54594/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Daniel Pravat.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `::lseek` with `os::lseek` in mesos.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 9c634ac928887b3f1a111f67ebb3fc5229c6fa16 
>   src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 
> 
> Diff: https://reviews.apache.org/r/54594/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>