You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/02/24 02:44:14 UTC
[GitHub] spark pull request: [SPARK-5910][SQL] Support for as in selectExpr
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/4736
[SPARK-5910][SQL] Support for as in selectExpr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark asExprs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4736.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4736
----
commit 5ba97e4d54098ca2de1c128e9e355e5e7f1b52bc
Author: Michael Armbrust <mi...@databricks.com>
Date: 2015-02-24T01:43:57Z
[SPARK-5910][SQL] Support for as in selectExpr
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5910][SQL] Support for as in selectExpr
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4736#issuecomment-75689829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27874/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5910][SQL] Support for as in selectExpr
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4736#issuecomment-75689824
[Test build #27874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27874/consoleFull) for PR 4736 at commit [`5ba97e4`](https://github.com/apache/spark/commit/5ba97e4d54098ca2de1c128e9e355e5e7f1b52bc).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class CheckAnalysis `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5910][SQL] Support for as in selectExpr
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4736#discussion_r25228631
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -40,7 +40,7 @@ class SqlParser extends AbstractSparkSQLParser {
def parseExpression(input: String): Expression = {
// Initialize the Keywords.
lexical.initialize(reservedWords)
- phrase(expression)(new lexical.Scanner(input)) match {
+ phrase(projection)(new lexical.Scanner(input)) match {
--- End diff --
We also use parseExpression to parse conditions provided in DataFrame.filter. Should we have a separate `parseProjection`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5910][SQL] Support for as in selectExpr
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5910][SQL] Support for as in selectExpr
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4736#issuecomment-75683446
[Test build #27874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27874/consoleFull) for PR 4736 at commit [`5ba97e4`](https://github.com/apache/spark/commit/5ba97e4d54098ca2de1c128e9e355e5e7f1b52bc).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org