You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Antti S. Lankila (JIRA)" <ji...@apache.org> on 2011/06/15 22:04:48 UTC
[jira] [Updated] (WICKET-3791) Improve AsynchronousDataStore
[ https://issues.apache.org/jira/browse/WICKET-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antti S. Lankila updated WICKET-3791:
-------------------------------------
Attachment: help-asyncthread.diff
This approach makes the thread that wants to add files to the diskstore help with asyncthread by consuming entries from the async queue until its own work can be appended.
This should improve throughput during high load conditions and also prevent the case where multiple updates of same pageId become executed out of order (some updates queued could be updated after the direct updates have been performed) because all work to be performed will be done through the queue in the queue insertion order.
> Improve AsynchronousDataStore
> -----------------------------
>
> Key: WICKET-3791
> URL: https://issues.apache.org/jira/browse/WICKET-3791
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 1.5-RC4
> Reporter: Martin Grigorov
> Fix For: 1.5-RC5
>
> Attachments: help-asyncthread.diff
>
>
> org.apache.wicket.pageStore.AsynchronousDataStore (ADS) is designed to wrap another IDataStore and save the serialized pages in a different thread.
> The class is only used in unit tests.
> Running org.apache.wicket.page.persistent.disk.DiskDataStoreTest.test1() with ADS seems to be actually slower than running it w/o ADS.
> We need to review the code in ADS and either improve it to scale better or drop this class completely.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira