You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/24 12:05:22 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
xiaoxiang781216 opened a new pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891
## Summary
Let's check ISIG flag directly instead since pid is sent by user and the modification will surprise user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698441535
> @xiaoxiang781216 - I would need more context here.
from https://man7.org/linux/man-pages/man3/termios.3.html:
```
ISIG When any of the characters INTR, QUIT, SUSP, or DSUSP are
received, generate the corresponding signal.
```
When ISIG is clear, serial driver should skip the signal generation code. The old implementattion achieve this behaviour by changing pid to -1, but it isn't good to modify the value provided by user without caution. So this PR check ISIG directly instead and keep pid intact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698441535
> @xiaoxiang781216 - I would need more context here.
from https://man7.org/linux/man-pages/man3/termios.3.html:
```
ISIG When any of the characters INTR, QUIT, SUSP, or DSUSP are
received, generate the corresponding signal.
```
When ISIG is clear, serial driver should skip the signal generation code. The old implementattion achieve this behaviour by changing pid to -1, but it isn't good to modify the value provided by user without caution. So this PR check ISIG directly instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698441535
> @xiaoxiang781216 - I would need more context here.
from https://man7.org/linux/man-pages/man3/termios.3.html:
```
ISIG When any of the characters INTR, QUIT, SUSP, or DSUSP are
received, generate the corresponding signal.
```
When ISIG is clear, serial driver should skip the signal generation code. The old implementattion achieve this behaviour by changing pid to -1, but it isn't good to modify the value provided by user without caution. So this PR check ISIG directly instead and keep pid intact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698441535
> @xiaoxiang781216 - I would need more context here.
from https://man7.org/linux/man-pages/man3/termios.3.html:
```
ISIG When any of the characters INTR, QUIT, SUSP, or DSUSP are
received, generate the corresponding signal.
```
When ISIG is clear, serial driver should skip the signal generation code. The old implementattion achieve this behaviour by changing pid to -1, but it isn't good to modify the value provided by user without caution. So this PR check ISIG directly instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698394909
@xiaoxiang781216 - I would need more context here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698394909
@xiaoxiang781216 - I would need more context here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org