You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/30 08:15:53 UTC
[GitHub] [submarine] noidname01 opened a new pull request #624: SUBMARINE-878. Modify E2E LoginIT with page object
noidname01 opened a new pull request #624:
URL: https://github.com/apache/submarine/pull/624
### What is this PR for?
Modify E2E LoginIT with page object
-->
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-878
### How should this be tested?
```bash
# Step1: Run Submarine workbench on 127.0.0.1:8080 by operator
# Step2: Run testcase
cd submarine-cloud-v2
# Usage: ./hack/run_frontend_e2e.sh ${testcase}
# Example:
./hack/run_frontend_e2e.sh notebookIT
```
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] noidname01 commented on pull request #624: SUBMARINE-878. Modify E2E LoginIT with page object
Posted by GitBox <gi...@apache.org>.
noidname01 commented on pull request #624:
URL: https://github.com/apache/submarine/pull/624#issuecomment-871210188
@kevin85421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #624: SUBMARINE-878. Modify E2E LoginIT with page object
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #624:
URL: https://github.com/apache/submarine/pull/624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #624: SUBMARINE-878. Modify E2E LoginIT with page object
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #624:
URL: https://github.com/apache/submarine/pull/624#discussion_r662774821
##########
File path: submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/datadictIT.java
##########
@@ -47,14 +48,14 @@ public static void tearDown(){
// @Test TODO(kevin85421): Due to the undeterministic behavior of travis, I decide to comment it.
public void dataDictTest() throws Exception {
String URL = getURL("http://127.0.0.1", 8080);
+
Sidebars sidebars = new Sidebars(URL);
+ LoginPage loginPage = new LoginPage();
// Login
LOG.info("Login");
- pollingWait(By.cssSelector("input[ng-reflect-name='userName']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("admin");
- pollingWait(By.cssSelector("input[ng-reflect-name='password']"), MAX_BROWSER_TIMEOUT_SEC).sendKeys("admin");
- clickAndWait(By.cssSelector("button[class='login-form-button ant-btn ant-btn-primary']"));
- pollingWait(By.cssSelector("a[routerlink='/workbench/experiment']"), MAX_BROWSER_TIMEOUT_SEC);
+ loginPage.Login();
+
Review comment:
empty line
##########
File path: submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/departmentIT.java
##########
@@ -51,11 +52,13 @@ public void dataNavigation() throws Exception {
Sidebars sidebars = new Sidebars(URL);
// Login
- Login();
+ LoginPage loginPage = new LoginPage();
+ loginPage.Login();
// Routing to department page
sidebars.gotoDepartment();
+
Review comment:
empty line
##########
File path: submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java
##########
@@ -52,12 +53,11 @@ public void workspaceNavigation() throws Exception {
String URL = getURL("http://127.0.0.1", 8080);
Sidebars sidebars = new Sidebars(URL);
Review comment:
empty line
##########
File path: submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/interpreterIT.java
##########
@@ -48,13 +49,14 @@ public static void tearDown(){
@Test
public void workspaceNavigation() throws Exception {
String URL = getURL("http://127.0.0.1", 8080);
+
Sidebars sidebars = new Sidebars(URL);
+
Review comment:
empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org