[GitHub] [hive] deniskuzZ commented on a diff in pull request #4477: HIVE-27050: Restrict reducer extrapolation to contain number of small…

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #4477:
URL: https://github.com/apache/hive/pull/4477#discussion_r1270679500


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -231,10 +231,17 @@ public static void validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Tab
   }
 
   public static boolean isIcebergTable(Table table) {
-    return table.isNonNative() && 
-            table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG;
+    return table.isNonNative() &&
+            ((table.getStorageHandler() != null && table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG) || 
+                    isIcebergTableType(table.getTTable().getParameters()));

Review Comment:
   no, shouldn't be



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org