You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/31 00:52:19 UTC
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9720: [improvement] Optimize send fragment logic to reduce send fragment timeout error
yiguolei commented on code in PR #9720:
URL: https://github.com/apache/incubator-doris/pull/9720#discussion_r885126765
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -225,6 +230,11 @@ Status FragmentExecState::prepare(const TExecPlanFragmentParams& params) {
}
Status FragmentExecState::execute() {
+ if (_need_wait_execution_trigger) {
+ // if _need_wait_execution_trigger is true, which means this instance
+ // is prepared but need to wait for the signal to do the rest execution.
+ _fragments_ctx->wait_for_start();
Review Comment:
Add a timeout here, avoid occupy the running thread too much time during exceptions.
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -225,6 +230,11 @@ Status FragmentExecState::prepare(const TExecPlanFragmentParams& params) {
}
Status FragmentExecState::execute() {
+ if (_need_wait_execution_trigger) {
+ // if _need_wait_execution_trigger is true, which means this instance
+ // is prepared but need to wait for the signal to do the rest execution.
+ _fragments_ctx->wait_for_start();
Review Comment:
Add a timeout here, avoid occupy the running thread too much time during exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org