You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2013/12/07 00:22:29 UTC
Re: Review Request 15653: Adds loadavg() convenience method to stout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 11:22 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Summary (updated)
-----------------
Adds loadavg() convenience method to stout
Repository: mesos-git
Description
-------
This patch includes a wrapper to get system load averages in uptime(1)
format. This is used by an upcoming patch which expose these averages
over master and slave stats.json endpoints.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
Diff: https://reviews.apache.org/r/15653/diff/
Testing
-------
make check and functional testing with endpoints.
Thanks,
Niklas Nielsen
Re: Review Request 15653: Adds loadavg() convenience method to stout
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Dec. 9, 2013, 9:42 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 849
> > <https://reviews.apache.org/r/15653/diff/4/?file=395223#file395223line849>
> >
> > Should this be ErrnoError?
>
> Niklas Nielsen wrote:
> getloadavg is most likely just a wrapper for sysctl (which sets errno), so yes - should probably be ErrnoError.
> I will get this in the new patch.
Cool - just changed to use ErrnoError().
I'll commit this patch if you do not have any further comments.
Thanks for the reviews!
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/#review30045
-----------------------------------------------------------
On Dec. 10, 2013, 1:27 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15653/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch includes a wrapper to get system load averages in uptime(1)
> format. This is used by an upcoming patch which expose these averages
> over master and slave stats.json endpoints.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
>
> Diff: https://reviews.apache.org/r/15653/diff/
>
>
> Testing
> -------
>
> make check and functional testing with endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15653: Adds loadavg() convenience method to stout
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Dec. 9, 2013, 9:42 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 849
> > <https://reviews.apache.org/r/15653/diff/4/?file=395223#file395223line849>
> >
> > Should this be ErrnoError?
getloadavg is most likely just a wrapper for sysctl (which sets errno), so yes - should probably be ErrnoError.
I will get this in the new patch.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/#review30045
-----------------------------------------------------------
On Dec. 6, 2013, 11:22 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15653/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 11:22 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch includes a wrapper to get system load averages in uptime(1)
> format. This is used by an upcoming patch which expose these averages
> over master and slave stats.json endpoints.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
>
> Diff: https://reviews.apache.org/r/15653/diff/
>
>
> Testing
> -------
>
> make check and functional testing with endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15653: Adds loadavg() convenience method to stout
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/#review30045
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/15653/#comment57552>
Should this be ErrnoError?
- Ben Mahler
On Dec. 6, 2013, 11:22 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15653/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 11:22 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch includes a wrapper to get system load averages in uptime(1)
> format. This is used by an upcoming patch which expose these averages
> over master and slave stats.json endpoints.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
>
> Diff: https://reviews.apache.org/r/15653/diff/
>
>
> Testing
> -------
>
> make check and functional testing with endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15653: Adds loadavg() convenience method to stout
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Dec. 12, 2013, 11:26 p.m., Ben Mahler wrote:
> > Did you forget to mark this submitted?
Sorry, indeed I did - I'll close it.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/#review30296
-----------------------------------------------------------
On Dec. 10, 2013, 1:27 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15653/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch includes a wrapper to get system load averages in uptime(1)
> format. This is used by an upcoming patch which expose these averages
> over master and slave stats.json endpoints.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
>
> Diff: https://reviews.apache.org/r/15653/diff/
>
>
> Testing
> -------
>
> make check and functional testing with endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15653: Adds loadavg() convenience method to stout
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/#review30296
-----------------------------------------------------------
Did you forget to mark this submitted?
- Ben Mahler
On Dec. 10, 2013, 1:27 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15653/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch includes a wrapper to get system load averages in uptime(1)
> format. This is used by an upcoming patch which expose these averages
> over master and slave stats.json endpoints.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
>
> Diff: https://reviews.apache.org/r/15653/diff/
>
>
> Testing
> -------
>
> make check and functional testing with endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15653: Adds loadavg() convenience method to stout
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15653/
-----------------------------------------------------------
(Updated Dec. 10, 2013, 1:27 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Using ErrnoError().
Repository: mesos-git
Description
-------
This patch includes a wrapper to get system load averages in uptime(1)
format. This is used by an upcoming patch which expose these averages
over master and slave stats.json endpoints.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c
Diff: https://reviews.apache.org/r/15653/diff/
Testing
-------
make check and functional testing with endpoints.
Thanks,
Niklas Nielsen