[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111351#comment-16111351 ] 

ASF GitHub Bot commented on FLINK-6105:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4316
  
    @zhangminglei, not sure if you saw @tedyu's comment on the Jira. There are more instances of this in the same file and package. If these are internal classes and Flink is not using `InterruptedIOException` then would the only effect be in logging a different exception?


> Properly handle InterruptedException in HadoopInputFormatBase
> -------------------------------------------------------------
>
>                 Key: FLINK-6105
>                 URL: https://issues.apache.org/jira/browse/FLINK-6105
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>
> When catching InterruptedException, we should throw InterruptedIOException instead of IOException.
> The following example is from HadoopInputFormatBase :
> {code}
>     try {
>       splits = this.mapreduceInputFormat.getSplits(jobContext);
>     } catch (InterruptedException e) {
>       throw new IOException("Could not get Splits.", e);
>     }
> {code}
> There may be other places where IOE is thrown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)