[jira] [Commented] (HBASE-15598) Potential null deference in CloneSnapshotProcedure#preCloneSnapshot()

["Matteo Bertozzi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229232#comment-15229232 ] 

Matteo Bertozzi commented on HBASE-15598:
-----------------------------------------

in what case you don't have any manifest?
can you add a test?

> Potential null deference in CloneSnapshotProcedure#preCloneSnapshot()
> ---------------------------------------------------------------------
>
>                 Key: HBASE-15598
>                 URL: https://issues.apache.org/jira/browse/HBASE-15598
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 15598.v1.patch
>
>
> In CloneSnapshotProcedure#preCloneSnapshot():
> {code}
>       ProcedureSyncWait.getMasterQuotaManager(env)
>         .checkNamespaceTableAndRegionQuota(getTableName(), manifest.getRegionManifestsMap().size());
> {code}
> Here is related code in SnapshotManifest#getRegionManifestsMap() :
> {code}
>     if (regionManifests == null || regionManifests.size() == 0) return null;
> ...
> {code}
> When there is no region manifest, null would be returned, resulting in NPE in CloneSnapshotProcedure#preCloneSnapshot()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)