You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2024/09/09 08:59:20 UTC
[PR] pick exception handle logic to 2.1 [doris]
yiguolei opened a new pull request, #40547:
URL: https://github.com/apache/doris/pull/40547
## Proposed changes
pick
https://github.com/apache/doris/pull/39536
https://github.com/apache/doris/pull/39913
https://github.com/apache/doris/pull/39964
https://github.com/apache/doris/pull/40020
https://github.com/apache/doris/pull/38960
https://github.com/apache/doris/pull/40092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] pick exception handle logic to 2.1 [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei closed pull request #40547: pick exception handle logic to 2.1
URL: https://github.com/apache/doris/pull/40547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] pick exception handle logic to 2.1 [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #40547:
URL: https://github.com/apache/doris/pull/40547#issuecomment-2337543007
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] pick exception handle logic to 2.1 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40547:
URL: https://github.com/apache/doris/pull/40547#issuecomment-2337537907
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] pick exception handle logic to 2.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #40547:
URL: https://github.com/apache/doris/pull/40547#discussion_r1749888444
##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -111,8 +111,8 @@ Status PageIO::write_page(io::FileWriter* writer, const std::vector<Slice>& body
return Status::OK();
}
-Status PageIO::read_and_decompress_page(const PageReadOptions& opts, PageHandle* handle,
- Slice* body, PageFooterPB* footer) {
+Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle* handle,
Review Comment:
warning: function 'read_and_decompress_page_' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle* handle,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/page_io.cpp:113:** 115 lines including whitespace and comments (threshold 80)
```cpp
Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle* handle,
^
```
</details>
##########
be/src/util/byte_buffer.h:
##########
@@ -23,19 +23,22 @@
#include <memory>
#include "common/logging.h"
+#include "common/status.h"
+#include "vec/common/allocator.h"
+#include "vec/common/allocator_fwd.h"
namespace doris {
struct ByteBuffer;
using ByteBufferPtr = std::shared_ptr<ByteBuffer>;
-struct ByteBuffer {
- static ByteBufferPtr allocate(size_t size) {
- ByteBufferPtr ptr(new ByteBuffer(size));
- return ptr;
+struct ByteBuffer : private Allocator<false> {
+ static Status allocate(const size_t size, ByteBufferPtr* ptr) {
+ RETURN_IF_CATCH_EXCEPTION({ *ptr = ByteBufferPtr(new ByteBuffer(size)); });
+ return Status::OK();
}
- ~ByteBuffer() { delete[] ptr; }
+ ~ByteBuffer() { Allocator<false>::free(ptr, capacity); }
Review Comment:
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
```cpp
~ByteBuffer() { Allocator<false>::free(ptr, capacity); }
^
```
##########
be/src/vec/sink/vtablet_block_convertor.cpp:
##########
@@ -182,12 +182,11 @@
return DecimalType(value);
}
-Status OlapTableBlockConvertor::_validate_column(RuntimeState* state, const TypeDescriptor& type,
- bool is_nullable, vectorized::ColumnPtr column,
- size_t slot_index, bool* stop_processing,
- fmt::memory_buffer& error_prefix,
- const uint32_t row_count,
- vectorized::IColumn::Permutation* rows) {
+Status OlapTableBlockConvertor::_internal_validate_column(
Review Comment:
warning: function '_internal_validate_column' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status OlapTableBlockConvertor::_internal_validate_column(
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/vtablet_block_convertor.cpp:184:** 267 lines including whitespace and comments (threshold 80)
```cpp
Status OlapTableBlockConvertor::_internal_validate_column(
^
```
</details>
##########
be/src/vec/sink/vtablet_block_convertor.cpp:
##########
@@ -182,12 +182,11 @@ DecimalType OlapTableBlockConvertor::_get_decimalv3_min_or_max(const TypeDescrip
return DecimalType(value);
}
-Status OlapTableBlockConvertor::_validate_column(RuntimeState* state, const TypeDescriptor& type,
- bool is_nullable, vectorized::ColumnPtr column,
- size_t slot_index, bool* stop_processing,
- fmt::memory_buffer& error_prefix,
- const uint32_t row_count,
- vectorized::IColumn::Permutation* rows) {
+Status OlapTableBlockConvertor::_internal_validate_column(
Review Comment:
warning: function '_internal_validate_column' has cognitive complexity of 331 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status OlapTableBlockConvertor::_internal_validate_column(
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/vtablet_block_convertor.cpp:189:** +1
```cpp
DCHECK((rows == nullptr) || (rows->size() == row_count));
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:191:** nesting level increased to 1
```cpp
auto set_invalid_and_append_error_msg = [&](int row) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:205:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
column_ptr == nullptr ? column : (column_ptr->get_nested_column_ptr());
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:206:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
const auto* null_map = column_ptr == nullptr ? nullptr : column_ptr->get_null_map_data().data();
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:207:** nesting level increased to 1
```cpp
const auto need_to_validate = [&null_map, this](size_t j, size_t row) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:211:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
switch (type.type) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:220:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (type.len > 0) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:226:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (int j = 0; j < row_count; ++j) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:230:** nesting level increased to 2
```cpp
auto check_column_type = [&]() {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:232:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (nullptr == dynamic_cast<const vectorized::ColumnString*>(&real_column)) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:240:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (invalid_count) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:241:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t j = 0; j < row_count; ++j) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:242:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
auto row = rows ? (*rows)[j] : j;
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:243:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (need_to_validate(j, row)) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:246:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (invalid) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:248:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
if (!st.ok()) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:252:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
if (str_val.size > type.len) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:259:** +1, nesting level increased to 6
```cpp
} else if (str_val.size > limit) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:269:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:269:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:279:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t j = 0; j < row_count; ++j) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:280:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!_filter_map[j]) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:281:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (is_nullable && column_ptr && column_ptr->is_null_at(j)) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:281:** +1
```cpp
if (is_nullable && column_ptr && column_ptr->is_null_at(j)) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:286:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (invalid) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:289:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(j));
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:289:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(j));
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:301:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t j = 0; j < row_count; ++j) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:302:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
auto row = rows ? (*rows)[j] : j;
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:303:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (need_to_validate(j, row)) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:308:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (dec_val.greater_than_scale(type.scale)) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:312:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (code != E_DEC_OK) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:318:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (dec_val > max_decimalv2 || dec_val < min_decimalv2) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:318:** +1
```cpp
if (dec_val > max_decimalv2 || dec_val < min_decimalv2) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:328:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (invalid) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:329:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:329:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:343:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (int j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:345:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:347:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid_count) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:348:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (size_t j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:349:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
auto row = rows ? (*rows)[j] : j; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:350:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (need_to_validate(j, row)) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:361:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:367:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:343:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (int j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:345:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:347:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid_count) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:348:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (size_t j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:349:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
auto row = rows ? (*rows)[j] : j; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:350:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (need_to_validate(j, row)) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:361:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:371:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:343:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (int j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:345:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:347:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid_count) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:348:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (size_t j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:349:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
auto row = rows ? (*rows)[j] : j; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:350:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (need_to_validate(j, row)) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:361:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:375:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:343:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (int j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:345:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:347:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid_count) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:348:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
for (size_t j = 0; j < row_count; ++j) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:349:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
auto row = rows ? (*rows)[j] : j; \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:350:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (need_to_validate(j, row)) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +1
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:353:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (dec_val > max_decimal || dec_val < min_decimal) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:361:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
if (invalid) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:379:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:362:** expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:390:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t r = 0; r < row_count; ++r) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:391:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t c = offsets[r - 1]; c < offsets[r]; ++c) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:396:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_validate_column(state, nested_type, type.contains_nulls[0],
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:396:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_validate_column(state, nested_type, type.contains_nulls[0],
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:408:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t r = 0; r < row_count; ++r) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:409:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t c = offsets[r - 1]; c < offsets[r]; ++c) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:414:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_validate_column(state, key_type, type.contains_nulls[0],
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:414:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_validate_column(state, key_type, type.contains_nulls[0],
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:417:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_validate_column(state, val_type, type.contains_nulls[1],
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:417:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_validate_column(state, val_type, type.contains_nulls[1],
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:427:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t sc = 0; sc < column_struct->tuple_size(); ++sc) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:428:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_validate_column(state, type.children[sc], type.contains_nulls[sc],
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:428:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_validate_column(state, type.children[sc], type.contains_nulls[sc],
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:443:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if ((!is_nullable || type == TYPE_OBJECT) && column_ptr) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:443:** +1
```cpp
if ((!is_nullable || type == TYPE_OBJECT) && column_ptr) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:443:** +1
```cpp
if ((!is_nullable || type == TYPE_OBJECT) && column_ptr) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:444:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (int j = 0; j < row_count; ++j) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:445:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
auto row = rows ? (*rows)[j] : j;
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:446:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (null_map[j] && !_filter_map[row]) {
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:449:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^
```
**be/src/common/status.h:619:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/vtablet_block_convertor.cpp:449:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^
```
**be/src/common/status.h:621:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org