You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by gm...@apache.org on 2006/08/10 15:15:14 UTC
svn commit: r430377 - in /forrest/trunk/site-author/resources/images:
ASF-us-2006-web_masthead.jpg apache_con_asia_header.png
Author: gmcdonald
Date: Thu Aug 10 06:15:13 2006
New Revision: 430377
URL: http://svn.apache.org/viewvc?rev=430377&view=rev
Log:
ApacheCon images to go with commit 430376
Added:
forrest/trunk/site-author/resources/images/ASF-us-2006-web_masthead.jpg (with props)
forrest/trunk/site-author/resources/images/apache_con_asia_header.png (with props)
Added: forrest/trunk/site-author/resources/images/ASF-us-2006-web_masthead.jpg
URL: http://svn.apache.org/viewvc/forrest/trunk/site-author/resources/images/ASF-us-2006-web_masthead.jpg?rev=430377&view=auto
==============================================================================
Binary file - no diff available.
Propchange: forrest/trunk/site-author/resources/images/ASF-us-2006-web_masthead.jpg
------------------------------------------------------------------------------
svn:mime-type = image/jpeg
Added: forrest/trunk/site-author/resources/images/apache_con_asia_header.png
URL: http://svn.apache.org/viewvc/forrest/trunk/site-author/resources/images/apache_con_asia_header.png?rev=430377&view=auto
==============================================================================
Binary file - no diff available.
Propchange: forrest/trunk/site-author/resources/images/apache_con_asia_header.png
------------------------------------------------------------------------------
svn:mime-type = image/png
Re: atomic commits
Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 11/08/2006 12:14 Ross Gardler a écrit :
> David Crossley wrote:
>> Gav.... wrote:
>>
>>> Yep, sorry about that.
>>
>>
>> No worries, just helping to get you going smoothly.
>>
>> Another thing. Please try to add any relevant Jira issue
>> numbers to the commit log message.
>
> For anyone who doesn't know why it may be worth a reminder...
>
> Adding FOR-200 to a commit log message, such as "did XYZ (FOR-200)"
> will allow the commit to be crossrefenced in FOR-200 in the issue
> tracker, as can be seen at the bottom of http://tinyurl.com/erxsu
Yes and it's an excellent feature, indeed.
Is it documented in our site, I can't find it.
>
> Ross
>
>
RE: atomic commits (was: r430376 and r430377)
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: Ross Gardler [mailto:rgardler@apache.org]
> Sent: Friday, 11 August 2006 6:14 PM
> To: dev@forrest.apache.org
> Subject: Re: atomic commits (was: r430376 and r430377)
>
> David Crossley wrote:
> > Gav.... wrote:
> >
> >>Yep, sorry about that.
> >
> >
> > No worries, just helping to get you going smoothly.
> >
> > Another thing. Please try to add any relevant Jira issue
> > numbers to the commit log message.
>
> For anyone who doesn't know why it may be worth a reminder...
>
> Adding FOR-200 to a commit log message, such as "did XYZ (FOR-200)"
> will allow the commit to be crossrefenced in FOR-200 in the issue
> tracker, as can be seen at the bottom of http://tinyurl.com/erxsu
>
> Ross
Thanks Guys for the Info, I did see this happening and should have followed
Suit.
I did however find a handy svn command and redeemed myself hopefully by
Changing the log message to include the Jira Issue. Will Jira pick this
Up now do you think ?
Command used for ref :-
svn propset -r 430376 --revprop svn:log "Changing ApacheCon images to load
from locally resized images (FOR-907)"
property 'svn:log' set on repository revision 430376
svn propset -r 430377 --revprop svn:log "ApacheCon images to go with commit
430376 (FOR-907)"
property 'svn:log' set on repository revision 430377
Gav...
Re: atomic commits (was: r430376 and r430377)
Posted by Ross Gardler <rg...@apache.org>.
David Crossley wrote:
> Gav.... wrote:
>
>>Yep, sorry about that.
>
>
> No worries, just helping to get you going smoothly.
>
> Another thing. Please try to add any relevant Jira issue
> numbers to the commit log message.
For anyone who doesn't know why it may be worth a reminder...
Adding FOR-200 to a commit log message, such as "did XYZ (FOR-200)"
will allow the commit to be crossrefenced in FOR-200 in the issue
tracker, as can be seen at the bottom of http://tinyurl.com/erxsu
Ross
Re: atomic commits (was: r430376 and r430377)
Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> Yep, sorry about that.
No worries, just helping to get you going smoothly.
Another thing. Please try to add any relevant Jira issue
numbers to the commit log message.
-David
RE: atomic commits (was: r430376 and r430377)
Posted by "Gav...." <br...@brightontown.com.au>.
Yep, sorry about that.
Gav...
> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Friday, 11 August 2006 8:55 AM
> To: Forrest Developers List
> Subject: atomic commits (was: r430376 and r430377)
>
> Please do commits together when they belong together, i.e.
> r430376 - /forrest/trunk/site-author/skinconf.xml
> and these images should be done in a single atomic commit.
>
> There is a risk that someone does their 'svn update'
> in between your commits, then they get a broken build.
> Not critical in this case.
>
> Atomic commits have many benefits, e.g. easier to revert
> when needed.
>
> Sure, i realise that it is easy to forget some pieces.
>
> -David
>
> > Author: gmcdonald
> > Date: Thu Aug 10 06:15:13 2006
> > New Revision: 430377
> >
> > URL: http://svn.apache.org/viewvc?rev=430377&view=rev
> > Log:
> > ApacheCon images to go with commit 430376
> >
> > Added:
> > forrest/trunk/site-author/resources/images/ASF-us-2006-
> web_masthead.jpg (with props)
> > forrest/trunk/site-
> author/resources/images/apache_con_asia_header.png (with props)
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.405 / Virus Database: 268.10.9/416 - Release Date: 8/10/2006
atomic commits (was: r430376 and r430377)
Posted by David Crossley <cr...@apache.org>.
Please do commits together when they belong together, i.e.
r430376 - /forrest/trunk/site-author/skinconf.xml
and these images should be done in a single atomic commit.
There is a risk that someone does their 'svn update'
in between your commits, then they get a broken build.
Not critical in this case.
Atomic commits have many benefits, e.g. easier to revert
when needed.
Sure, i realise that it is easy to forget some pieces.
-David
> Author: gmcdonald
> Date: Thu Aug 10 06:15:13 2006
> New Revision: 430377
>
> URL: http://svn.apache.org/viewvc?rev=430377&view=rev
> Log:
> ApacheCon images to go with commit 430376
>
> Added:
> forrest/trunk/site-author/resources/images/ASF-us-2006-web_masthead.jpg (with props)
> forrest/trunk/site-author/resources/images/apache_con_asia_header.png (with props)