You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by Peter Eichenauer <ma...@peter-eichenauer.de> on 2023/07/07 16:06:50 UTC

RateLimitFilter

Hi,

thank you for adding the RateLimitFilter in Tomcat 9.0.76. It is working 
as expected, but I wonder if the log message during initialisation is 
correct: Actual is [{3}] per [{4}] milliseconds. [{5}].

To me it looks like that parameter {4} is printed in seconds.

For example, this is my web.xml configuration:
	<filter>
		<filter-name>RateLimitFilter</filter-name>
		<filter-class>org.apache.catalina.filters.RateLimitFilter</filter-class>
		<init-param>
			<param-name>bucketDuration</param-name>
			<param-value>10</param-value>
		</init-param>
		<init-param>
			<param-name>bucketRequests</param-name>
			<param-value>10</param-value>
		</init-param>
	</filter>

my log shows:
[RateLimitFilter] initialized with [10] requests per [10] seconds. 
Actual is [16] per [16] milliseconds.

Thanks again,
Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org

Re: RateLimitFilter

Posted by Rémy Maucherat <re...@apache.org>.
On Fri, Jul 7, 2023 at 6:07 PM Peter Eichenauer
<ma...@peter-eichenauer.de> wrote:
>
> Hi,
>
> thank you for adding the RateLimitFilter in Tomcat 9.0.76. It is working
> as expected, but I wonder if the log message during initialisation is
> correct: Actual is [{3}] per [{4}] milliseconds. [{5}].
>
> To me it looks like that parameter {4} is printed in seconds.
>
> For example, this is my web.xml configuration:
>         <filter>
>                 <filter-name>RateLimitFilter</filter-name>
>                 <filter-class>org.apache.catalina.filters.RateLimitFilter</filter-class>
>                 <init-param>
>                         <param-name>bucketDuration</param-name>
>                         <param-value>10</param-value>
>                 </init-param>
>                 <init-param>
>                         <param-name>bucketRequests</param-name>
>                         <param-value>10</param-value>
>                 </init-param>
>         </filter>
>
> my log shows:
> [RateLimitFilter] initialized with [10] requests per [10] seconds.
> Actual is [16] per [16] milliseconds.

Ok, it should be seconds instead.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org