You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/20 19:35:00 UTC
[jira] [Work logged] (BEAM-14204) [Playground] Tests for example repository
[ https://issues.apache.org/jira/browse/BEAM-14204?focusedWorklogId=759517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759517 ]
ASF GitHub Bot logged work on BEAM-14204:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 19:34
Start Date: 20/Apr/22 19:34
Worklog Time Spent: 10m
Work Description: miamihotline commented on code in PR #17226:
URL: https://github.com/apache/beam/pull/17226#discussion_r854488354
##########
playground/frontend/lib/modules/examples/repositories/models/get_example_request.dart:
##########
@@ -23,4 +23,14 @@ class GetExampleRequestWrapper {
final SDK sdk;
GetExampleRequestWrapper(this.path, this.sdk);
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetExampleRequestWrapper &&
+ path == other.path &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => path.hashCode ^ sdk.hashCode;
Review Comment:
Hello, @KonradJanica! Thank you for the review, fixed that in the last commit.
##########
playground/frontend/lib/modules/examples/repositories/models/get_list_of_examples_request.dart:
##########
@@ -23,4 +23,14 @@ class GetListOfExamplesRequestWrapper {
final String? category;
GetListOfExamplesRequestWrapper({required this.sdk, required this.category});
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetListOfExamplesRequestWrapper &&
+ category == other.category &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => category.hashCode ^ sdk.hashCode;
Review Comment:
Hello, @KonradJanica! Thank you for the review, fixed that in the last commit.
Issue Time Tracking
-------------------
Worklog Id: (was: 759517)
Time Spent: 40m (was: 0.5h)
> [Playground] Tests for example repository
> -----------------------------------------
>
> Key: BEAM-14204
> URL: https://issues.apache.org/jira/browse/BEAM-14204
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Alexander Zhuravlev
> Assignee: Alexander Zhuravlev
> Priority: P2
> Labels: beam-playground-frontend
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)