You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/20 07:15:21 UTC

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 opened a new pull request #479: Add tooltip for dashboard component

kezhenxu94 opened a new pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479


   <img width="537" alt="Screen Shot 2021-04-20 at 15 12 46" src="https://user-images.githubusercontent.com/15965696/115353480-1f554300-a1eb-11eb-8181-b14c5ca095ee.png">
   
   This is a simple enhancement to support a tooltip in the UI template.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823070722


   Alright.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823038487


   Related to https://github.com/apache/skywalking/issues/6682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823055498


   Dose this need to support edit on the page?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823054713


   Dose this 
   
   > > Could you replace the icon? This icon has been used. @kezhenxu94
   > 
   > Where have we used this?
   
   Instance Attributes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823053562


   > Could you replace the icon? This icon has been used. @kezhenxu94
   
   Where have we used this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823041148


   So, I could write this on the configuration page?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823052915


   Could you replace the icon? This icon has been used. @kezhenxu94 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823053945


   > Could you replace the icon? This icon has been used. @kezhenxu94
   
   Which one do you prefer? I thought this icon `info` was good for `tips` 🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 edited a comment on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823049081


   > So, I could write this on the configuration page?
   
   Add `tips` property in the ui template such as https://github.com/apache/skywalking/blob/527d772575ebb8b4bd86ab4add8651aefeede8d4/oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/vm.yml#L40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823051505


   > Hope she is not sleepy. She was vaccinated this morning.
   
   Haha, I took my daughter vaccinated in the morning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823050007


   OK, once this will be on UI(config page) and in the template. This is good to me.
   Wait for @Fine0830 to check the codes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823050228


   Hope she is not sleepying. She was vaccinated this morning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823069327


   @Fine0830 
   
   > Without editable, this information will be a mystery when the user want to edit the content, or a new contributor wants to add a new page.
   
   To follow this, you could either work on this now, or create an issue to track. We need this in this iteration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823054272


   > > Could you replace the icon? This icon has been used. @kezhenxu94
   > 
   > Where have we used this?
   
   Instance attributes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823055498


   Dose this need to support to edit on the page?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823057174


   > Dose this need to support to edit on the page?
   
   I hope this can be merged first and I’ll push my commit to the main repo, I think it is ok to be not editable on the ui page, otherwise, I’ll request your help @Fine0830 then 😅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823058996


   Without editable, this information will be a mystery when the user want to edit the content, or a new contributor wants to add a new page. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823058200


   > Dose this need to support to edit on the page?
   
   Yes, it should. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823049081


   > So, I could write this on the configuration page?
   
   Add `tips` in the ui template such as https://github.com/apache/skywalking/blob/527d772575ebb8b4bd86ab4add8651aefeede8d4/oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/vm.yml#L40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #479: Add tooltip for dashboard component

Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #479:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/479#issuecomment-823050228


   Hope she is not sleepy. She was vaccinated this morning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org