You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/05/25 08:00:43 UTC
[GitHub] [eventmesh] Alonexc opened a new issue, #4022: [Enhancement] contains() is a legacy method that is equivalent to containsValue()
Alonexc opened a new issue, #4022:
URL: https://github.com/apache/eventmesh/issues/4022
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request


located at:
eventmesh-registry-plugin/eventmesh-registry-consul/src/main/java/org/apache/eventmesh/registry/consul/service/HeatBeatScheduler.java line 94
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java line 190
analysis and explanation:
Hashtable.contains(Object) and ConcurrentHashMap.contains(Object) are legacy methods for testing if the given object is a value in the hash table. They are often mistaken for containsKey, which checks whether the given object is a key in the hash table.
If you intended to check whether the given object is a key in the hash table, use containsKey instead. If you really intended to check whether the given object is a value in the hash table, use containsValue for clarity.
### Describe the solution you'd like
change to use containsValue().
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #4022:
URL: https://github.com/apache/eventmesh/issues/4022#issuecomment-1641248648
> can i take this issue
Someone has already submitted a pr. are you interested in other issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #4022: [Enhancement] contains() is a legacy method that is equivalent to containsValue()
URL: https://github.com/apache/eventmesh/issues/4022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] contains() is a legacy method that is equivalent to containsValue() (eventmesh)
Posted by "sumitdethe27 (via GitHub)" <gi...@apache.org>.
sumitdethe27 commented on issue #4022:
URL: https://github.com/apache/eventmesh/issues/4022#issuecomment-1640042099
can i take this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org