[jira] (KAFKA-20364) Remove control records reads from metadata module

["Jun Cho (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-20364 ]


    Jun Cho deleted comment on KAFKA-20364:
    ---------------------------------

was (Author: JIRAUSER312949):
Hi, I'd like to take this one on.

 

From what I could see, the scope comes down to `KRAFT_VERSION` — `KRAFT_VOTERS` doesn't appear to be read in the metadata module anywhere. The only reader is `MetadataLoader.loadControlRecords()`, which updates the `featureName=kraftVersion` gauge on `MetadataLoader.FinalizedLevel`.

My thought is to add a `Supplier<KRaftVersion>` to `MetadataLoader.Builder`, mirroring the existing `highWaterMarkAccessor` pattern, and wire it to `KafkaRaftClient.kraftVersion()`, which is already public. The metric could then be refreshed in `handleCommit` when the value changes, so its name and location stay as they are.

 

Would this direction work, or would you prefer moving the metric itself into the raft
module? Happy to adjust based on your guidance.

Thanks!

> Remove control records reads from metadata module
> -------------------------------------------------
>
>                 Key: KAFKA-20364
>                 URL: https://issues.apache.org/jira/browse/KAFKA-20364
>             Project: Kafka
>          Issue Type: Task
>            Reporter: John Mannooparambil
>            Assignee: Jun Cho
>            Priority: Major
>
> KRAFT_VERSION and KRAFT_VOTERS control records are currently both read in the metadata module. Control records shouldn't be needed outside the raft module. Ideally this functionality should not be included.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)