[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9746: disable bloomfilter is pass rate is very high

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #9746:
URL: https://github.com/apache/incubator-doris/pull/9746#discussion_r880000234


##########
be/src/olap/bloom_filter_predicate.h:
##########
@@ -157,6 +160,14 @@ void BloomFilterColumnPredicate<T>::evaluate(vectorized::IColumn& column, uint16
             new_size += _specific_filter->find_olap_engine(cell_value);
         }
     }
+    // If the pass rate is very high, for example > 50%, then the bloomfilter is useless.
+    _evaluated_rows += *size;
+    _passed_rows += new_size;
+    if (_evaluated_rows > 1000) {

Review Comment:
   sure 1000 is a better row count ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org