[jira] [Commented] (CAMEL-19897) camel-core: remove isStatisticsEnabled from type converter statistics

["Otavio Rodolfo Piske (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-19897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860523#comment-17860523 ] 

Otavio Rodolfo Piske commented on CAMEL-19897:
----------------------------------------------

I'll try this one again for 4.7.0. Let's see how it goes.

> camel-core: remove isStatisticsEnabled from type converter statistics
> ---------------------------------------------------------------------
>
>                 Key: CAMEL-19897
>                 URL: https://issues.apache.org/jira/browse/CAMEL-19897
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 4.1.0
>            Reporter: Otavio Rodolfo Piske
>            Priority: Major
>             Fix For: 4.x
>
>
> We have made an attempt to further cleanup internal APIs by removing the `isStatisticsEnabled` method from the type converter statistics but we had to [revert the changes|https://github.com/apache/camel/pull/11507]. 
> Although the removal proceeds well in some cases, it seems to cause SpringXML-based code to fail. For instance [SpringTypeConverterRegistryStatisticsEnabledTest|https://github.com/apache/camel/blob/f7b02f41e64c26d1aa8bf46f9b699ccee8484a4e/components/camel-spring-xml/src/test/java/org/apache/camel/spring/impl/SpringTypeConverterRegistryStatisticsEnabledTest.java] fails and [it seems that the flag that enables the statics is ignored|https://github.com/apache/camel/blob/f7b02f41e64c26d1aa8bf46f9b699ccee8484a4e/components/camel-spring-xml/src/test/resources/org/apache/camel/spring/impl/SpringTypeConverterRegistryStatisticsEnabledTest.xml#L29]. 
> In short: we need to investigate and fix why SpringXML needs the `isStatisticsEnabled`. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)