You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/02 07:45:08 UTC
[GitHub] [incubator-nuttx] takayoshi-k opened a new pull request, #6761: drivers/wireless/gs2200m: Fix short bit length
takayoshi-k opened a new pull request, #6761:
URL: https://github.com/apache/incubator-nuttx/pull/6761
## Summary
Despite being a mask variable for a 32-bit value, it was 16 bits long.
## Impact
GS2200M Wi-Fi driver
## Testing
Operate telnetd and tcpserver at the same time on spresense by spresense:wifi config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6761: drivers/wireless/gs2200m: Fix short bit length
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #6761:
URL: https://github.com/apache/incubator-nuttx/pull/6761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6761: drivers/wireless/gs2200m: Fix short bit length
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6761:
URL: https://github.com/apache/incubator-nuttx/pull/6761#discussion_r935293893
##########
drivers/wireless/gs2200m.c:
##########
@@ -602,7 +602,7 @@ static void _remove_and_free_pkt(FAR struct gs2200m_dev_s *dev, uint8_t c)
static void _remove_all_pkt(FAR struct gs2200m_dev_s *dev, uint8_t c)
{
FAR struct pkt_dat_s *pkt_dat;
- uint16_t mask;
+ uint32_t mask;
mask = 1 << c;
Review Comment:
Optional
```suggestion
mask = UINT32_C(1) << c;
```
##########
drivers/wireless/gs2200m.c:
##########
@@ -375,7 +375,7 @@ static bool _enable_cid(uint32_t *cid_bits, char cid, bool on)
static bool _cid_is_set(uint32_t *cid_bits, char cid)
{
- uint16_t mask = 1 << _cid_to_uint8(cid);
+ uint32_t mask = 1 << _cid_to_uint8(cid);
Review Comment:
Optional
```suggestion
uint32_t mask = UINT32_C(1) << _cid_to_uint8(cid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org