You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/02 18:39:00 UTC
[jira] [Commented] (CB-14249) Inconsistency in platforms vs tools
release in cordova-coho docs
[ https://issues.apache.org/jira/browse/CB-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567348#comment-16567348 ]
ASF GitHub Bot commented on CB-14249:
-------------------------------------
brodybits opened a new pull request #189: CB-14249 ensure platform changes are in a dev version (partial workaround doc fix)
URL: https://github.com/apache/cordova-coho/pull/189
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All
### What does this PR do?
Add section with note to ensure that changes are made in a "-dev" version.
This is a partial workaround for the fundamental issue in [CB-14249](https://issues.apache.org/jira/browse/CB-14249), contributed in response to the discussion in <https://github.com/apache/cordova-android/pull/469>. This kind of workaround was already applied in <https://github.com/apache/cordova-android/pull/470>, <https://github.com/apache/cordova-ios/pull/379>, <https://github.com/apache/cordova-android/pull/454>, and several other places.
I hope we can resolve the inconsistency in release procedure for platforms vs tools described in [CB-14249](https://issues.apache.org/jira/browse/CB-14249) someday, with agreement via <de...@cordova.apache.org>. I cannot promise when I will get a chance to take care of this.
### Merge procedure
- Should be merged by squash (second commit is there to splve a problem with the first commit)
### What testing has been done on this change?
- Quick visual check
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. (not true for second commit, which should be squashed anyway)
- ~~Added automated test coverage as appropriate for this change.~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Inconsistency in platforms vs tools release in cordova-coho docs
> ----------------------------------------------------------------
>
> Key: CB-14249
> URL: https://issues.apache.org/jira/browse/CB-14249
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> The procedure for tools release is that once the tools release is made, version must be incremented to new -dev version. This does not seem to be the case for platforms release.
> I think we did not catch this for a long time since the coho tools automatically marks new "-dev" version in master, in case of release from master. But in case of release from non-master branch this does not seem to be the case.
> This should be relatively straightforward except for another factor: in case a proposed release does not pass the vote the procedure is different: for tools it says we should go on with the next release while for platforms it says we should do a revert to go back to the previous "-dev" before fixing. I think this inconsistency should also be resolved, somehow.
> As a workaround I would mark the "-dev" version in a patch branch before committing any changes to a non-master branch, for example: https://github.com/apache/cordova-android/pull/470
> P.S. I think it would be best to get agreement via [mailto:dev@cordova.apache.org], cannot tell for sure when I will get a chance to do this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org