You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/02/17 09:02:23 UTC
Review Request 31105: CLOUDSTACK-8259: test_routers.py - Code
improvement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31105/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8259
https://issues.apache.org/jira/browse/CLOUDSTACK-8259
Repository: cloudstack-git
Description
-------
1. Read all the test data from test_data.py, removed services dict from test case
2. Read host credentials from configurableData section
Additional change:
Increased the memory and cpu for default service offering from 128 to 256 to avoid SSH failures.
Diffs
-----
test/integration/component/test_routers.py 0a74234
tools/marvin/marvin/config/test_data.py e3645a7
Diff: https://reviews.apache.org/r/31105/diff/
Testing
-------
Yes. All test cases passed.
Thanks,
Gaurav Aradhye
Re: Review Request 31105: CLOUDSTACK-8259: test_routers.py - Code
improvement
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31105/#review72705
-----------------------------------------------------------
Ship it!
8bfda973c2d22b075c51fc6a055017b5796dd88b master
- SrikanteswaraRao Talluri
On Feb. 17, 2015, 8:02 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31105/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 8:02 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8259
> https://issues.apache.org/jira/browse/CLOUDSTACK-8259
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Read all the test data from test_data.py, removed services dict from test case
> 2. Read host credentials from configurableData section
>
> Additional change:
> Increased the memory and cpu for default service offering from 128 to 256 to avoid SSH failures.
>
>
> Diffs
> -----
>
> test/integration/component/test_routers.py 0a74234
> tools/marvin/marvin/config/test_data.py e3645a7
>
> Diff: https://reviews.apache.org/r/31105/diff/
>
>
> Testing
> -------
>
> Yes. All test cases passed.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>