You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adriangb (via GitHub)" <gi...@apache.org> on 2026/05/21 14:17:42 UTC
[I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
adriangb opened a new issue, #22435:
URL: https://github.com/apache/datafusion/issues/22435
Sub-issue of #22418. Port `HashTableLookupExpr` to use the `try_to_proto` / `try_from_proto` hooks added in #21929.
Replace the `HashTableLookupExpr` arm in `datafusion/proto/src/physical_plan/{to_proto,from_proto}.rs` with `try_to_proto` / `try_from_proto` impls next to `HashTableLookupExpr`. See the `Column` / `BinaryExpr` migrations in #21929 for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "AnuragRaut08 (via GitHub)" <gi...@apache.org>.
AnuragRaut08 commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4510314347
Hi @adriangb, I’d like to work on this issue.
I’ll follow the existing `Column` / `BinaryExpr` migrations from #21929 as reference and port `HashTableLookupExpr` to use the `try_to_proto` / `try_from_proto` hooks.
I’ll open a draft PR once I have the initial implementation ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4511055238
Sounds good. CI / GitHub actions seems to be gummed up, it may take some time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4652104290
Fixed in #22451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "AnuragRaut08 (via GitHub)" <gi...@apache.org>.
AnuragRaut08 commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4511041984
Thanks! Yes, absolutely — I’ll start with `HashTableLookupExpr` and `DynamicFilterPhysicalExpr` first and focus on getting those done properly before taking on anything else.
I’m currently waiting for #21929 to land on `main`, and once it does I’ll begin implementing the migrations following the `Column` / `BinaryExpr` pattern and open draft PRs incrementally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "AnuragRaut08 (via GitHub)" <gi...@apache.org>.
AnuragRaut08 commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4511070901
Got it, thanks for the heads up! No worries — I’ll keep an eye on #21929 and wait for the CI / Actions situation to settle before starting the migration work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4511023962
Okay, sounds good. You've assigned two of these issues already, are you okay starting with this one and the dynamic filters one and going tfrom there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb closed issue #22435: Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto`
URL: https://github.com/apache/datafusion/issues/22435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Port `HashTableLookupExpr` to use `try_to_proto` / `try_from_proto` [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on issue #22435:
URL: https://github.com/apache/datafusion/issues/22435#issuecomment-4567240977
Please base your PR on the helpers documented in #22418 (added in #22596). If you've already written this against the older inline pattern, the migration is small — see the second commit of #22596 for examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org