You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by bbodnar <gi...@git.apache.org> on 2017/07/30 23:45:35 UTC
[GitHub] cxf pull request #300: CXF-7371: use objectweb-asm to extract parameter-name...
GitHub user bbodnar opened a pull request:
https://github.com/apache/cxf/pull/300
CXF-7371: use objectweb-asm to extract parameter-names from the debug-info of the service-class
Suggested fix for https://issues.apache.org/jira/browse/CXF-7371.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbodnar/cxf master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit 914fc30d55968717aef05d31b852161752e3a378
Author: bbodnar <ba...@ser.de>
Date: 2017-07-30T23:18:24Z
CXF-7371: use objectweb-asm to extract parameter-names from the debug-info of the service-class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #300: CXF-7371: use objectweb-asm to extract parameter-names from ...
Posted by bbodnar <gi...@git.apache.org>.
Github user bbodnar commented on the issue:
https://github.com/apache/cxf/pull/300
OK, I will do so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #300: CXF-7371: use objectweb-asm to extract parameter-names from ...
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the issue:
https://github.com/apache/cxf/pull/300
This creates a hard dependency on a particular ASM implementation and as such is not something we will merge. You will likely need to update the org.apache.cxf.common.util.ASMHelper class to support the ClassReader (in addition to the current ClassWriter stuff) and make sure all the asm calls go through there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #300: CXF-7371: use objectweb-asm to extract parameter-name...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #300: CXF-7371: use objectweb-asm to extract parameter-names from ...
Posted by bbodnar <gi...@git.apache.org>.
Github user bbodnar commented on the issue:
https://github.com/apache/cxf/pull/300
There is no good solution for reading classes with ASM without direct coding against concrete ASM-classes (the "normal" (visitor-based) way isn't usable with reflection/proxying, because the visitors are in ASM >v3 classes (no longer interfaces); the non-visitor-based ways (tree, SAX-events) require optional ASM-libraries, whose existence must here surely not be assumed).
I see under this circumstances the only reasonable solution to extend the current (self-made) byte-code-parser to handle the Java8-constants.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---