You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2017/05/07 22:23:58 UTC

Review Request 59041: RANGER-1561:Good coding practice in Ranger recommended by static code analysis

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59041/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1561
    https://issues.apache.org/jira/browse/RANGER-1561


Repository: ranger


Description
-------

RANGER-1561:Good coding practice in Ranger recommended by static code analysis


Diffs
-----

  hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java c4c2a2a 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10007.java a886945 


Diff: https://reviews.apache.org/r/59041/diff/1/


Testing
-------

Tested locally


Thanks,

Ramesh Mani


Re: Review Request 59041: RANGER-1561:Good coding practice in Ranger recommended by static code analysis

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59041/#review174138
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 7, 2017, 10:23 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59041/
> -----------------------------------------------------------
> 
> (Updated May 7, 2017, 10:23 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1561
>     https://issues.apache.org/jira/browse/RANGER-1561
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1561:Good coding practice in Ranger recommended by static code analysis
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java c4c2a2a 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10007.java a886945 
> 
> 
> Diff: https://reviews.apache.org/r/59041/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>