You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/27 13:26:11 UTC
[GitHub] tillrohrmann commented on a change in pull request #7176:
[FLINK-11005] Define flink-sql-client uber-jar dependencies via artifactSet
tillrohrmann commented on a change in pull request #7176: [FLINK-11005] Define flink-sql-client uber-jar dependencies via artifactSet
URL: https://github.com/apache/flink/pull/7176#discussion_r236660749
##########
File path: flink-libraries/flink-sql-client/pom.xml
##########
@@ -144,30 +144,19 @@ under the License.
<executions>
<!-- Exclude all flink-dist files and only include flink-table and flink-sql-client -->
<execution>
+ <id>shade</id>
Review comment:
Yes, it should be `shade-flink`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services