[GitHub] [apisix] Sn0rt commented on a diff in pull request #9437: chore(ci): use real clickhouse server in ci

["Sn0rt (via GitHub)" <gi...@apache.org>]

Sn0rt commented on code in PR #9437:
URL: https://github.com/apache/apisix/pull/9437#discussion_r1188027184


##########
.github/workflows/build.yml:
##########
@@ -136,6 +136,7 @@ jobs:
           make ci-env-up project_compose_ci=ci/pod/docker-compose.${{ steps.test_env.outputs.type }}.yml
           [[ ${{ steps.test_env.outputs.type }} != first ]] && sudo ./ci/init-${{ steps.test_env.outputs.type }}-test-service.sh after
           echo "Linux launch services, done."
+

Review Comment:
   remove this newline (it's not needed



##########
ci/pod/docker-compose.plugin.yml:
##########
@@ -324,10 +324,21 @@ services:
     networks:
       vector_net:
 
+  clickhouse:
+    image: clickhouse/clickhouse-server:23.4.2-alpine
+    container_name: clickhouse
+    ports:
+      - '8123:8123'
+      - '9000:9000'

Review Comment:
   why create 9000? I only find the port 8123 port has been used. 



##########
ci/init-plugin-test-service.sh:
##########
@@ -51,6 +51,8 @@ after() {
     # configure keycloak
     docker exec apisix_keycloak bash /tmp/kcadm_configure_cas.sh
     docker exec apisix_keycloak bash /tmp/kcadm_configure_university.sh
+
+    echo "CREATE TABLE default.test (\`host\` String, \`client_ip\` String, \`route_id\` String, \`service_id\` String, \`@timestamp\` String, PRIMARY KEY(\`@timestamp\`)) ENGINE = MergeTree()" | curl 'http://localhost:8123/'

Review Comment:
   should we set the logger format? or is this the default struct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org