You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/25 15:29:16 UTC
[GitHub] [commons-crypto] geoffreyblake opened a new pull request #95:
[CRYPTO-139] Makefile.common support for aarch64 native libraries
geoffreyblake opened a new pull request #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95
CRYPTO-139 has been outstanding for a long time, and AArch64 build support is still lacking from this package. This patch adds the needed Makefile additions to build successfully on AWS a1 instances running RHEL8.
Ran on RHEL8 for AArch64:
`mvn clean verify`
Build and tests all pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] vanzin edited a comment on issue #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
vanzin edited a comment on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-606969651
Hi, since this doesn't affect other builds I'll merge it, although I don't really know how to test it.
I think the biggest obstacle to releasing is having a committer who knows how to build the final package (one jar file for all the supported architectures). The committers who created the initial release(s) have kinda been silent for a long time, and I personally don't really know how to build everything (afaik it's a pretty manual process), nor do I have access to anything but a Linux box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] vanzin merged pull request #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
vanzin merged pull request #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] vanzin commented on issue #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
vanzin commented on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-606969651
Hi, since this doesn't affect other build I'll merge it, although I don't really know how to test it.
I think the biggest obstacle to releasing is having a committer who knows how to build the final package (one jar file for all the supported architectures). The committers who created the initial release(s) have kinda been silent for a long time, and I personally don't really know how to build everything (afaik it's a pretty manual process), nor do I have access to anything but a Linux box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] geoffreyblake commented on issue #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
geoffreyblake commented on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-608082448
Looking at the last released Jar, the only environments built were for Linux x86 and x86_64, even though the build files have support for many more environments. I'll take a look, maybe we can get Travis CI to do releases to maven for the project instead of having to do so manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] coveralls edited a comment on issue #95:
[CRYPTO-139] Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-603909379
[](https://coveralls.io/builds/29726042)
Coverage remained the same at 72.988% when pulling **cfebfe54fa52db58d9882c418ff7b97bf92de6c0 on geoffreyblake:aarch64_build** into **ca9a6bb46ba12cc130161e83a243cf6afab1dcef on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] geoffreyblake commented on issue #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
geoffreyblake commented on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-606759806
Can we merge this please? Also, what is the main blocker for building and releasing the artifact for Linux-aarch64 for a new release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] geoffreyblake commented on issue #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
geoffreyblake commented on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-605319842
How is this patch causing a build on MacOS amd64 to fail? This seems to have nothing to do with an internal Java error during a unit test. Can the build be re-run? I don't see anything suspicious in the logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] coveralls commented on issue #95: [CRYPTO-139]
Makefile.common support for aarch64 native libraries
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #95: [CRYPTO-139] Makefile.common support for aarch64 native libraries
URL: https://github.com/apache/commons-crypto/pull/95#issuecomment-603909379
[](https://coveralls.io/builds/29610020)
Coverage remained the same at 72.988% when pulling **f3b1be6b41059e1fc0275d49bbdc9e4f6f61ff43 on geoffreyblake:aarch64_build** into **ca9a6bb46ba12cc130161e83a243cf6afab1dcef on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services