You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/08 23:44:22 UTC

[GitHub] [hbase] taklwu commented on a change in pull request #2211: HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…

taklwu commented on a change in pull request #2211:
URL: https://github.com/apache/hbase/pull/2211#discussion_r467514589



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
##########
@@ -104,7 +104,8 @@ static Status splitLog(String filename, CancelableProgressable p, Configuration
     // encountered a bad non-retry-able persistent error.
     try {
       SplitLogWorkerCoordination splitLogWorkerCoordination =
-        server.getCoordinatedStateManager().getSplitLogWorkerCoordination();

Review comment:
       +1 on this fix, I hit this issue and figure out if we set `HBASE_SPLIT_WAL_COORDINATED_BY_ZK` in `TestClusterRestartFailoverSplitWithoutZk`, the test fails.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org