You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe Jr." <wr...@rowe-clan.net> on 2010/04/07 04:21:38 UTC
Re: svn commit: r915660 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ldap.xml
include/ap_mmn.h modules/ldap/util_ldap.c
On 2/23/2010 10:02 PM, covener@apache.org wrote:
> Author: covener
> Date: Wed Feb 24 04:02:06 2010
> New Revision: 915660
>
> URL: http://svn.apache.org/viewvc?rev=915660&view=rev
> Log:
> make some sense of the difference between "Client" and "Global" certs in mod_ldap.
> PR46541
>
> Submitted By: Paul Reder, Eric Covener
> Reviewed By: Eric Covener
>
>
> Modified:
> httpd/httpd/trunk/CHANGES
> httpd/httpd/trunk/docs/manual/mod/mod_ldap.xml
> httpd/httpd/trunk/include/ap_mmn.h
> httpd/httpd/trunk/modules/ldap/util_ldap.c
>
> Modified: httpd/httpd/trunk/include/ap_mmn.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mmn.h?rev=915660&r1=915659&r2=915660&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/include/ap_mmn.h (original)
> +++ httpd/httpd/trunk/include/ap_mmn.h Wed Feb 24 04:02:06 2010
> @@ -217,15 +217,16 @@
> * 20100208.0 (2.3.6-dev) ap_socache_provider_t API changes to store and iterate
> * 20100208.1 (2.3.6-dev) Added forward member to proxy_conn_rec
> * 20100208.2 (2.3.7-dev) Added ap_log_command_line().
> + * 20100223.1 (2.3.7-dev) LDAP client_certs per-server moved to per-dir
> *
> */
>
> #define MODULE_MAGIC_COOKIE 0x41503234UL /* "AP24" */
>
> #ifndef MODULE_MAGIC_NUMBER_MAJOR
> -#define MODULE_MAGIC_NUMBER_MAJOR 20100208
> +#define MODULE_MAGIC_NUMBER_MAJOR 20100223
> #endif
> -#define MODULE_MAGIC_NUMBER_MINOR 2 /* 0...n */
> +#define MODULE_MAGIC_NUMBER_MINOR 1 /* 0...n */
>
> /**
> * Determine if the server's current MODULE_MAGIC_NUMBER is at least a
>
> Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
No. This isn't a BC break, so do *not* bump _MAJOR. Reverting to 20100208, which
is harmless for tests of >= 20100208, but harmful to modules seeking an exact API.
Re: svn commit: r915660 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ldap.xml
include/ap_mmn.h modules/ldap/util_ldap.c
Posted by "William A. Rowe Jr." <wr...@apache.org>.
On 4/6/2010 9:21 PM, William A. Rowe Jr. wrote:
>> + * 20100223.1 (2.3.7-dev) LDAP client_certs per-server moved to per-dir
>
> No. This isn't a BC break, so do *not* bump _MAJOR. Reverting to 20100208, which
> is harmless for tests of >= 20100208, but harmful to modules seeking an exact API.
Ok, I was completely wrong, didn't parse the entire commit history to see that two
modules were interlocking here. Changing those cross-module structures does break
the MMN - my bad.