You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2011/01/07 23:28:13 UTC

svn commit: r1056545 - /httpcomponents/httpclient/trunk/pom.xml

Author: sebb
Date: Fri Jan  7 22:28:13 2011
New Revision: 1056545

URL: http://svn.apache.org/viewvc?rev=1056545&view=rev
Log:
Ensure source jars have full manifest entries

Modified:
    httpcomponents/httpclient/trunk/pom.xml

Modified: httpcomponents/httpclient/trunk/pom.xml
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/pom.xml?rev=1056545&r1=1056544&r2=1056545&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/pom.xml (original)
+++ httpcomponents/httpclient/trunk/pom.xml Fri Jan  7 22:28:13 2011
@@ -112,6 +112,20 @@
             </goals>
           </execution>
         </executions>
+        <configuration>
+          <archive>
+            <!-- Ensure source jars have full manifest entries (note: defaults aren't suitable) -->
+            <manifestEntries>
+              <Specification-Title>HttpComponents ${project.name}</Specification-Title>
+              <Specification-Version>${project.version}</Specification-Version>
+              <Specification-Vendor>The Apache Software Foundation</Specification-Vendor>
+              <Implementation-Title>HttpComponents ${project.name}</Implementation-Title>
+              <Implementation-Version>${project.version}</Implementation-Version>
+              <Implementation-Vendor>The Apache Software Foundation</Implementation-Vendor>
+              <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id>
+            </manifestEntries>
+          </archive>
+        </configuration>
       </plugin>
       <plugin>
         <artifactId>maven-javadoc-plugin</artifactId>



Re: svn commit: r1056545 - /httpcomponents/httpclient/trunk/pom.xml

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2011-01-07 at 22:32 +0000, sebb AT ASF wrote:
> It looks like something similar could be done for the maven-jar-plugin
> - at present the manifest entries are defined in each of the component
> POMs.
> 
> I think those 3 definitions could be merged into the httpclient parent.
> 
> Thoughts?
> 

Sure. If that can be done, go for it.

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: svn commit: r1056545 - /httpcomponents/httpclient/trunk/pom.xml

Posted by sebb AT ASF <se...@apache.org>.
It looks like something similar could be done for the maven-jar-plugin
- at present the manifest entries are defined in each of the component
POMs.

I think those 3 definitions could be merged into the httpclient parent.

Thoughts?

On 7 January 2011 22:28,  <se...@apache.org> wrote:
> Author: sebb
> Date: Fri Jan  7 22:28:13 2011
> New Revision: 1056545
>
> URL: http://svn.apache.org/viewvc?rev=1056545&view=rev
> Log:
> Ensure source jars have full manifest entries
>
> Modified:
>    httpcomponents/httpclient/trunk/pom.xml
>
> Modified: httpcomponents/httpclient/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/pom.xml?rev=1056545&r1=1056544&r2=1056545&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/pom.xml (original)
> +++ httpcomponents/httpclient/trunk/pom.xml Fri Jan  7 22:28:13 2011
> @@ -112,6 +112,20 @@
>             </goals>
>           </execution>
>         </executions>
> +        <configuration>
> +          <archive>
> +            <!-- Ensure source jars have full manifest entries (note: defaults aren't suitable) -->
> +            <manifestEntries>
> +              <Specification-Title>HttpComponents ${project.name}</Specification-Title>
> +              <Specification-Version>${project.version}</Specification-Version>
> +              <Specification-Vendor>The Apache Software Foundation</Specification-Vendor>
> +              <Implementation-Title>HttpComponents ${project.name}</Implementation-Title>
> +              <Implementation-Version>${project.version}</Implementation-Version>
> +              <Implementation-Vendor>The Apache Software Foundation</Implementation-Vendor>
> +              <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id>
> +            </manifestEntries>
> +          </archive>
> +        </configuration>
>       </plugin>
>       <plugin>
>         <artifactId>maven-javadoc-plugin</artifactId>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org