You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/27 00:55:06 UTC
[GitHub] [arrow] mariusvniekerk opened a new pull request #8059: [java][jdbc] Improve error messages for unsupported types.
mariusvniekerk opened a new pull request #8059:
URL: https://github.com/apache/arrow/pull/8059
When the JDBC adapter creates consumers for unsupported data types we can provide
some slightly more helpful error messaging.
Additionally there were some NPE issues when the close was happening in this error
state, masking the actual exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rymurr commented on pull request #8059: [MINOR] [java][jdbc] Improve error messages for unsupported types.
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #8059:
URL: https://github.com/apache/arrow/pull/8059#issuecomment-681960845
Hey @mariusvniekerk with intellij I have found that running `mvn clean install` from a terminal first helps a lot. Also ensure that under Build -> Compiler -> Java Compiler you have 'Javac with error prone' set (which may require installign the error prone plugin). That should help w/ compiling and running the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #8059: [MINOR] [java][jdbc] Improve error messages for unsupported types.
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8059:
URL: https://github.com/apache/arrow/pull/8059#issuecomment-681323737
@mariusvniekerk thank you for the PR generally it looks good but could you add a unit tests to demonstrate cover the cases that generated NPE?
Also, would you mind opening JIRA to track this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mariusvniekerk commented on pull request #8059: [MINOR] [java][jdbc] Improve error messages for unsupported types.
Posted by GitBox <gi...@apache.org>.
mariusvniekerk commented on pull request #8059:
URL: https://github.com/apache/arrow/pull/8059#issuecomment-681947055
I tried setup that up but I could not get intellij to be able to run a test suite at all. Are there some docs around how to set up the ide to work properly for arrow work?
I'm more a python dev than Java one so not quite sure how to proceed on this codebase.
I spotted the error when using uuid types which for the jdbc types map to OTHER
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8059: [MINOR] [java][jdbc] Improve error messages for unsupported types.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8059:
URL: https://github.com/apache/arrow/pull/8059#issuecomment-681202023
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org