You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/11/26 15:16:12 UTC
[jira] [Commented] (SOLR-5864) Remove previous SolrCore as
parameter on reload
[ https://issues.apache.org/jira/browse/SOLR-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226210#comment-14226210 ]
ASF subversion and git services commented on SOLR-5864:
-------------------------------------------------------
Commit 1641819 from [~tomasflobbe] in branch 'dev/trunk'
[ https://svn.apache.org/r1641819 ]
SOLR-5864: Remove previous SolrCore as parameter on reload
> Remove previous SolrCore as parameter on reload
> -----------------------------------------------
>
> Key: SOLR-5864
> URL: https://issues.apache.org/jira/browse/SOLR-5864
> Project: Solr
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Tomás Fernández Löbbe
> Priority: Trivial
> Attachments: SOLR-5864.patch, SOLR-5864.patch, SOLR-5864.patch, SOLR-5864.patch
>
>
> Currently the reload method is reload(SolrResourceLoader resourceLoader, SolrCore prev), but all the times it’s called with “prev” being the same as “this”:
> core.reload(resourceLoader, core).
> Frankly, I don’t think it even makes sense to call it in other way (it would be just to create the first reader with a different core than the one its being reloaded?)
> I think we should just remove the SolrCore parameter and let the "reload" method always reload the core where it's being called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org