You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jacob Janco <jj...@gmail.com> on 2016/12/20 12:05:06 UTC
Re: Review Request 51028: Fix broken tests post batched event
allocation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 12:05 p.m.)
Review request for mesos and Jiang Yan Xu.
Summary (updated)
-----------------
Fix broken tests post batched event allocation.
Bugs: MESOS-3157
https://issues.apache.org/jira/browse/MESOS-3157
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
> On Jan. 19, 2017, 3:15 a.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2994-2998
> > <https://reviews.apache.org/r/51028/diff/6/?file=1590243#file1590243line2994>
> >
> > This test is already paused, all of these should be run with a paused clock, are any of them not?
Earlier in the test:
// Allow the allocation timer to measure time.
Clock::resume();
- Jacob
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162237
-----------------------------------------------------------
On Jan. 27, 2017, 2:33 a.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 2:33 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6904
> https://issues.apache.org/jira/browse/MESOS-6904
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Per MESOS-3157, if cluster events with the possibility
> of triggering an allocation occur rapidly and test
> assertions depend on gleaning information from assumed
> order, it is likely they will fail due to lack of parity
> between event and actual allocation. Ensure that expected
> allocations occur.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
>
> Diff: https://reviews.apache.org/r/51028/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162237
-----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (lines 2933 - 2936)
<https://reviews.apache.org/r/51028/#comment233551>
Seems clearer if we increment allocations after the settle?
src/tests/hierarchical_allocator_tests.cpp (lines 2994 - 2998)
<https://reviews.apache.org/r/51028/#comment233550>
This test is already paused, all of these should be run with a paused clock, are any of them not?
- Benjamin Mahler
On Dec. 21, 2016, 5:58 a.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 5:58 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-3157
> https://issues.apache.org/jira/browse/MESOS-3157
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Per MESOS-3157, if cluster events with the possibility
> of triggering an allocation occur rapidly and test
> assertions depend on gleaning information from assumed
> order, it is likely they will fail due to lack of parity
> between event and actual allocation. Ensure that expected
> allocations occur.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
>
> Diff: https://reviews.apache.org/r/51028/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 10:36 a.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 10:07 p.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 10:04 p.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review163624
-----------------------------------------------------------
Bad patch!
Reviews applied: [51028, 52534, 51027]
Failed command: python support/apply-reviews.py -n -r 52534
Error:
2017-01-31 05:57:33 URL:https://reviews.apache.org/r/52534/diff/raw/ [4204/4204] -> "52534.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:226
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/16924/console
- Mesos Reviewbot
On Jan. 31, 2017, 1:41 a.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 1:41 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6904
> https://issues.apache.org/jira/browse/MESOS-6904
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Per MESOS-3157, if cluster events with the possibility
> of triggering an allocation occur rapidly and test
> assertions depend on gleaning information from assumed
> order, it is likely they will fail due to lack of parity
> between event and actual allocation. Ensure that expected
> allocations occur.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c
>
> Diff: https://reviews.apache.org/r/51028/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 1:41 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Jan. 30, 2017, 11:15 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Updated review to depend on /r/52534
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 2:33 a.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Jan. 23, 2017, 3:08 p.m., Jiang Yan Xu wrote:
> > Modulo @bmahler's comments.
Also this is not a complete set of tests that we should fix and we should follow up with more test fixes.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162722
-----------------------------------------------------------
On Jan. 18, 2017, 11:29 p.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 11:29 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6904
> https://issues.apache.org/jira/browse/MESOS-6904
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Per MESOS-3157, if cluster events with the possibility
> of triggering an allocation occur rapidly and test
> assertions depend on gleaning information from assumed
> order, it is likely they will fail due to lack of parity
> between event and actual allocation. Ensure that expected
> allocations occur.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
>
> Diff: https://reviews.apache.org/r/51028/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
> On Jan. 23, 2017, 11:08 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 3765
> > <https://reviews.apache.org/r/51028/diff/6/?file=1590243#file1590243line3765>
> >
> > Is `s/performing/; performed/?` better?
yea I like that better
- Jacob
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162722
-----------------------------------------------------------
On Jan. 27, 2017, 2:33 a.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 2:33 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6904
> https://issues.apache.org/jira/browse/MESOS-6904
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Per MESOS-3157, if cluster events with the possibility
> of triggering an allocation occur rapidly and test
> assertions depend on gleaning information from assumed
> order, it is likely they will fail due to lack of parity
> between event and actual allocation. Ensure that expected
> allocations occur.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
>
> Diff: https://reviews.apache.org/r/51028/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162722
-----------------------------------------------------------
Fix it, then Ship it!
Modulo @bmahler's comments.
src/tests/hierarchical_allocator_tests.cpp (line 3764)
<https://reviews.apache.org/r/51028/#comment234047>
"agents" and "in" can be in one string.
src/tests/hierarchical_allocator_tests.cpp (line 3765)
<https://reviews.apache.org/r/51028/#comment234050>
Is `s/performing/; performed/?` better?
src/tests/hierarchical_allocator_tests.cpp (line 3768)
<https://reviews.apache.org/r/51028/#comment234053>
`runs`: If we consider "one allocation is one offercallback", one allocation run generates many allocations, one per framework.
So s/allocation runs/allocations/
- Jiang Yan Xu
On Jan. 18, 2017, 11:29 p.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 11:29 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6904
> https://issues.apache.org/jira/browse/MESOS-6904
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Per MESOS-3157, if cluster events with the possibility
> of triggering an allocation occur rapidly and test
> assertions depend on gleaning information from assumed
> order, it is likely they will fail due to lack of parity
> between event and actual allocation. Ensure that expected
> allocations occur.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
>
> Diff: https://reviews.apache.org/r/51028/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 11:29 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Change JIRA.
Bugs: MESOS-6904
https://issues.apache.org/jira/browse/MESOS-6904
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco
Re: Review Request 51028: Fix tests with rapidly triggered
allocations.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/
-----------------------------------------------------------
(Updated Dec. 21, 2016, 5:58 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Fix AllocationRunTimerMetrics logic.
Summary (updated)
-----------------
Fix tests with rapidly triggered allocations.
Bugs: MESOS-3157
https://issues.apache.org/jira/browse/MESOS-3157
Repository: mesos
Description
-------
- Per MESOS-3157, if cluster events with the possibility
of triggering an allocation occur rapidly and test
assertions depend on gleaning information from assumed
order, it is likely they will fail due to lack of parity
between event and actual allocation. Ensure that expected
allocations occur.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
Diff: https://reviews.apache.org/r/51028/diff/
Testing
-------
make check
Thanks,
Jacob Janco