[GitHub] [spark] mgaido91 commented on a change in pull request #24464: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans

[GitBox <gi...@apache.org>]

mgaido91 commented on a change in pull request #24464: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans
URL: https://github.com/apache/spark/pull/24464#discussion_r280973556
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
 ##########
 @@ -177,6 +167,41 @@ case class ExplainCommand(
   }
 }
 
+object ExplainCommand {
+  /**
+   * Initializes an `ExplainCommand` object by passing `LogicalPlan`. This logical plan will be
+   * run through the analyzer and optimizer when this command is actually run.
+   */
+  def apply(
+    logicalPlan: LogicalPlan,
+    extended: Boolean,
+    codegen: Boolean,
+    cost: Boolean): ExplainCommand = {
+    val sparkSession = SparkSession.active
+
+    val queryExecution =
+      if (logicalPlan.isStreaming) {
+        // This is used only by explaining `Dataset/DataFrame` created by `spark.readStream`, so the
+        // output mode does not matter since there is no `Sink`.
+        new IncrementalExecution(
+          sparkSession, logicalPlan, OutputMode.Append(), "<unknown>",
+          UUID.randomUUID, UUID.randomUUID, 0, OffsetSeqMetadata(0, 0))
+      } else {
+        sparkSession.sessionState.executePlan(logicalPlan)
+      }
+    new ExplainCommand(queryExecution, extended, codegen, cost)
+  }
+
+  /**
+   * This is mainly used for tests.
+   */
+  def apply(
+    logicalPlan: LogicalPlan,
 
 Review comment:
   nit: ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org