You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2016/06/14 11:55:49 UTC

[whimsy] branch master updated: close component on reuse

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  bba6b23   close component on reuse
bba6b23 is described below

commit bba6b2351611c7e511033b889e17257e6983e0ad
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Tue Jun 14 07:55:19 2016 -0400

    close component on reuse
---
 www/roster/views/committee.js.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/www/roster/views/committee.js.rb b/www/roster/views/committee.js.rb
index f1d0c84..ef6dc97 100644
--- a/www/roster/views/committee.js.rb
+++ b/www/roster/views/committee.js.rb
@@ -282,7 +282,8 @@ class PMCMember < React
   end
 
   # automatically open pending entries
-  def componentWillReceiveProps()
+  def componentWillReceiveProps(newprops)
+    @state = :closed if self.person != newprops.person
     @state = :open if @@person.date == 'pending'
   end
 
@@ -346,7 +347,8 @@ class PMCCommitter < React
   end
 
   # automatically open pending entries
-  def componentWillReceiveProps()
+  def componentWillReceiveProps(newprops)
+    @state = :closed if self.person != newprops.person
     @state = :open if @@person.date == 'pending'
   end
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].