You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/05 05:08:34 UTC

[GitHub] [spark] maropu commented on issue #27368: [SPARK-30651][SQL] Add detailed information for Aggregate operators in EXPLAIN FORMATTED

maropu commented on issue #27368: [SPARK-30651][SQL] Add detailed information for Aggregate operators in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/27368#issuecomment-582242678
 
 
   > I think we can keep empty Keys or Functions printed, which means the node has no Keys or Functions. Otherwise we don't know if the explain message means no Keys/Functions or we missed the details for them.
   What do you think? @dilipbiswal @maropu @cloud-fan
   
   +1, too.
   
   > > And do we need to filter more common logic for the three aggregate operators
   > I think it's a good idea. What do you think @maropu
   
   Looks fine to me, but can you do it in follow-up?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org