You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/09/10 17:58:51 UTC
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/520
use FauxtonAPI.url helper
covered by the attachment selenium test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton fauxton-api-url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #520
----
commit 1bb67aa0dac05ad3e33738c568564e90f3c2adea
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-09-10T15:51:23Z
use FauxtonAPI.url helper
covered by the attachment selenium test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/520#discussion_r39178890
--- Diff: app/addons/documents/doc-editor/actions.js ---
@@ -141,9 +141,13 @@ function (app, FauxtonAPI, ActionTypes) {
// store the xhr in parent scope to allow us to cancel any uploads if the user closes the modal
xhr = $.ajaxSettings.xhr();
+ var query = '?rev=' + params.rev;
--- End diff --
tthis name (query) threw me for a loop initially. Maybe name it revision?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/520#issuecomment-139313019
merged as 24953b29308682a9832870a9f33a1ad983ff5ca1 - thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/520#discussion_r39183307
--- Diff: app/addons/documents/doc-editor/actions.js ---
@@ -141,9 +141,13 @@ function (app, FauxtonAPI, ActionTypes) {
// store the xhr in parent scope to allow us to cancel any uploads if the user closes the modal
xhr = $.ajaxSettings.xhr();
+ var query = '?rev=' + params.rev;
--- End diff --
it is a query string, but for attachments it will always be the document revision right? either way still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/520#issuecomment-139296977
+1 code is working
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/520#discussion_r39181742
--- Diff: app/addons/documents/doc-editor/actions.js ---
@@ -141,9 +141,13 @@ function (app, FauxtonAPI, ActionTypes) {
// store the xhr in parent scope to allow us to cancel any uploads if the user closes the modal
xhr = $.ajaxSettings.xhr();
+ var query = '?rev=' + params.rev;
--- End diff --
it is a query string :)
https://en.wikipedia.org/wiki/Query_string
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/520#discussion_r39185880
--- Diff: app/addons/documents/doc-editor/actions.js ---
@@ -141,9 +141,13 @@ function (app, FauxtonAPI, ActionTypes) {
// store the xhr in parent scope to allow us to cancel any uploads if the user closes the modal
xhr = $.ajaxSettings.xhr();
+ var query = '?rev=' + params.rev;
--- End diff --
right that's true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: use FauxtonAPI.url helper
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/520
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---